itsleeds / pct

Get and reproduce data from the Propensity to Cycle Tool (PCT)
https://itsleeds.github.io/pct/
19 stars 10 forks source link

Task # 38 - Splits introductory vignette into 2. #86

Closed ccamara closed 3 years ago

ccamara commented 3 years ago

As per https://github.com/ITSLeeds/pct/issues/38 request.

Robinlovelace commented 3 years ago

Looks good to me @ccamara, I resolved some conflicts (did you start with the most recent, e.g. recently cloned) version of the repo? If it passes the CI tests above I plan to merge it and add you to as a contributor, if you like (do you have an ORCID ID if so?).

ccamara commented 3 years ago

Ok, will do it this weekend (as you can see, I'm just doing that on weekends and you may have updated the repo since last time I forked it) with the same date version (probably in another PR, as I don't want to lose time fixing conflicts)!

Robinlovelace commented 3 years ago

Thanks @ccamara if you have any questions on updating it just let me know.