itsmartashub / GPThemes

GPThemes is a Chrome and Firefox extension designed to improve the visual experience of ChatGPT with customisable accent colours, custom fonts, modern designs and custom chat bubble widths
https://chromewebstore.google.com/detail/gpthemes/bghdlfnkbghekhdadaokecnhkcodfcna
49 stars 5 forks source link

Implement full and custom width conversation view options #35

Closed itsmartashub closed 3 months ago

itsmartashub commented 4 months ago

1. Chat Width Customization [#1, #37]:

2. Prompt Field Width Customization [#37]:

3. Sync Feature for Prompt Field [#38]:

4. Implement responsive full-width adjustment for chat bubbles and prompt textarea when resizing window [#39]

Closes: #1, #37, #38, #39

itsmartashub commented 4 months ago

Fix edit icon disappearance in full-width mode

In the new UI, when the full-width option is enabled, the edit icon for user chats disappears due to the restricted width of the user chat element. This pull request aims to fix this issue by repositioning the edit icon and ensuring it remains visible and accessible to users. Additionally, we will address the overflow issue by applying overflow: visible to the user chat element, while thoroughly testing for any potential layout breaks caused by this change.

NeeRaj-2401 commented 4 months ago

hello @itsmartashub , i have some sugestions regarding the chat width implementation,

  1. i cant see edit msg icon on my msg
  2. can we have option something like slider to customize the width as per user's choice (with a min and max predefined)
itsmartashub commented 4 months ago
  1. Hmm, it looks like the prompt field in your screenshot is synchronized with the chat width, which makes me think you're not using the latest pushed full-chat-width version. In the most recent pushed version, I restyled the edit icon to be visible and on the right bottom side of the user chat (when in full width mode). I think it's more convenient there because the Cancel and Submit edit state buttons are immediately next to it.

image

  1. As I mentioned, I definitely plan to introduce custom width options, and I'm actually working on custom width sliders right now, and it's going great, lol 🥲

image

NeeRaj-2401 commented 4 months ago

Aah ok my bad, apologies :( Its looks good, thanks 🙌

NeeRaj-2401 commented 4 months ago

hello @itsmartashub , i did notice a small behaviour of chat-full-width implementation, it does maintain the selected width % even after smaller device breakpoint which shouldnt be the case

itsmartashub commented 4 months ago

hello @itsmartashub , i did notice a small behaviour of chat-full-width implementation, it does maintain the selected width % even after smaller device breakpoint which shouldnt be the case

Hi there, dear @NeeRaj-2401. Yap, I'm aware of that. Just I've got a lot on my plate these days and not a lot of free time to focus on the extension.

Also, since this extension is primarily for the desktop versions, I tend to work in a similar way. So, I always make sure everything is working properly on the desktop versions first, and then once I'm sure everything is tested, I move on to mobile (smaller breakpoints).

In this case, the full/custom width feature is far from finished, so mobile is even further away.

I hope you don't mind me asking, but I'm curious about why you think the currently selected width should be different at different breakpoints?

NeeRaj-2401 commented 3 months ago

I hope you don't mind me asking, but I'm curious about why you think the currently selected width should be different at different breakpoints?

The only reason 😅

itsmartashub commented 3 months ago

I hope you don't mind me asking, but I'm curious about why you think the currently selected width should be different at different breakpoints?

The only reason 😅

I understand that. But what if someone uses the extension on tablets or phones and wants the width to be custom, say, 85% instead of 100%? If I reset the width to 100% at the tablet/phones breakpoint, this feature wouldn't make sense on smaller devices/breakpoints, right? After all, you suggested the full-width feature (and there shouldn't be such "problems" with dynamic width), if I'm not mistaken. This slider customization is just a bonus.

But I can certainly look into what I can do when the user resizes the window if that would help you. If you have a better idea than changing the widths on the window resizing event to solve this, please suggest it.