search

itsmehemant7 / PyMovieDb

A Simple IMDb API for Python
MIT License
90 stars 18 forks source link

missing requirements file and lack of dependency packaging #2

Closed fcakyon closed 1 year ago

fcakyon commented 1 year ago

Thanks for the great package! I am facing some issues:

env

windows10, python3.10, miniconda env

steps

pip install PyMovieDb 
from PyMovieDb import IMDB

imdb = IMDB()
res = imdb.get_by_id("asdsad")

error

Traceback (most recent call last):
  File "...\lib\site-packages\PyMovieDb\__init__.py", line 2, in <module>
    from .imdb import IMDB
  File "...\lib\site-packages\PyMovieDb\imdb.py", line 5, in <module>
    from requests_html import HTMLSession
ModuleNotFoundError: No module named 'requests_html'
de-Generation commented 1 year ago

install requests-html module then:

pip3 install requests-html

fcakyon commented 1 year ago

@itsmehemant7 @de-Generation, it should be added to package requirements in setup.py https://github.com/itsmehemant7/PyMovieDb/blob/master/setup.py

Manually installing dependencies is not a good practice.

itsmehemant7 commented 1 year ago

requirements are added in the setup.py