itsmejr257 / pe

0 stars 0 forks source link

Solid Line From EconoCraftLogic to CommandFactory in DG #11

Open itsmejr257 opened 7 months ago

itsmejr257 commented 7 months ago

In the section EconoCraftLogic components, the class diagram provided appears to show a solid line from EconoCraftLogic to CommandFactory.

Given that CommandFactory is not a class-level attribute and instead, using in the initGame() is the solid line supposed to be a dotted line instead?

image.png

Here is a snippet of your class-level attributes

image.png

Here is the snippet of CommandFactory being used image.png

nus-se-script commented 7 months ago

Team's Response

Thank you for the feedback! We would like to adjust the severity to Low as it is a small mistake and is unlikely to affect normal operations of the product.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Solid line should be replaced with dash line for dependency

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


Screenshot 2024-04-19 at 5.44.37 PM.png

In the UI class diagram, I believe the Parser depends on CommandType, but does have an association to it. In this case the arrow should have a dash line.


[original: nus-cs2113-AY2324S2/pe-interim#46] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for pointing out the problem!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]