itsmeow / whisperwoods

Minecraft mod for Spooky Jam adding a few fearsome forest critters
Other
7 stars 10 forks source link

Redundant Texture whisperwoods #1

Closed SirJamesalot closed 4 years ago

SirJamesalot commented 4 years ago

Hey i get this Bug after installing. Hope you can fix it

`---- Minecraft Crash Report ---- // You should try our sister game, Minceraft!

Time: 10/28/19 12:22 PM Description: Rendering overlay

java.lang.IllegalStateException: Redundant texture list for particle whisperwoods:wisp at net.minecraft.client.particle.ParticleManager.func_215236_a(ParticleManager.java:201) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.particle.ParticleManager.lambda$null$0(ParticleManager.java:153) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.particle.ParticleManager$$Lambda$4463/558705318.run(Unknown Source) ~[?:?] {} at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1618) ~[?:1.8.0_51] {} at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1610) ~[?:1.8.0_51] {} at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) ~[?:1.8.0_51] {} at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) ~[?:1.8.0_51] {} at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1689) ~[?:1.8.0_51] {} at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) ~[?:1.8.0_51] {}

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head -- Thread: Client thread Stacktrace: at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:544)

-- Overlay render details -- Details: Overlay name: net.minecraft.client.gui.ResourceLoadProgressGui Stacktrace: at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:544) at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:890) at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:384) at net.minecraft.client.main.Main.main(SourceFile:155) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:56) at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$398/1625111587.call(Unknown Source) at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) at cpw.mods.modlauncher.Launcher.main(Launcher.java:65)

-- System Details -- Details: Minecraft Version: 1.14.4 Minecraft Version ID: 1.14.4 Operating System: Windows 10 (amd64) version 10.0 Java Version: 1.8.0_51, Oracle Corporation Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation Memory: 661385288 bytes (630 MB) / 1556611072 bytes (1484 MB) up to 3008888832 bytes (2869 MB) CPUs: 8 JVM Flags: 5 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx3228m -Xms256m -XX:PermSize=256m ModLauncher: 4.1.0+62+5bfa59b ModLauncher launch target: fmlclient ModLauncher naming: srg ModLauncher services: /eventbus-1.0.0-service.jar eventbus PLUGINSERVICE /forge-1.14.4-28.1.70.jar object_holder_definalize PLUGINSERVICE /forge-1.14.4-28.1.70.jar runtime_enum_extender PLUGINSERVICE /accesstransformers-1.0.0-shadowed.jar accesstransformer PLUGINSERVICE /forge-1.14.4-28.1.70.jar capability_inject_definalize PLUGINSERVICE /forge-1.14.4-28.1.70.jar runtimedistcleaner PLUGINSERVICE /forge-1.14.4-28.1.70.jar fml TRANSFORMATIONSERVICE FML: 28.1 Forge: net.minecraftforge:28.1.70 FML Language Providers: javafml@28.1 minecraft@1 Mod List: Fragile Glass and Thin Ice 1.14.4-2.5.1.jar Fragile Glass and Thin Ice {fragileglassft@2.5.1 SIDED_SETUP} doubledoors_1.14-1.1.jar Double Doors {doubledoors@1.1 SIDED_SETUP} zombiehs_1.14-2.1.2.jar Zombie Horse Spawn {zombiehs@2.1.2 SIDED_SETUP} Wyrmroost-1.14.4-1.0.2.jar Wyrmroost {wyrmroost@1.0.2 SIDED_SETUP} Mine and Slash-1.14.4-2.9.2.jar Mine and Slash {mmorpg@2.8.0 SIDED_SETUP} jei-1.14.4-6.0.0.18.jar Just Enough Items {jei@6.0.0.18 SIDED_SETUP} Druidcraft-1.14-0.1.31.jar Druidcraft {druidcraft@0.1.12 SIDED_SETUP} Realistic Ulities 3.2.jar Realistic Ultities {realistic@3.2 SIDED_SETUP} Upgrade Aquatic Wave Three v6 - Beta 1.0.8.jar Upgrade Aquatic {upgrade_aquatic@1.0.7 SIDED_SETUP} comforts-FORGE-1.14.4-2.0-beta3.jar Comforts {comforts@FORGE-1.14.4-2.0-beta3 SIDED_SETUP} citadel-1.0.0.jar Citadel {citadel@1.0.0 COMMON_SETUP} DungeonCrawl-1.14.4-1.4.0.jar Dungeon Crawl {dungeoncrawl@1.4.0 SIDED_SETUP} betteranimalsplus-1.14.4-7.1.2.jar Better Animals Plus {betteranimalsplus@7.1.2 SIDED_SETUP} TheVeggieWay-1.14.4-2.0.26.jar The Veggie Way {veggie_way@2.0.26 SIDED_SETUP} The-Endergetic-Expansion-1.14.4-v1.0.jar The Endergetic Expansion {endergetic@1.0 SIDED_SETUP} Customized-Dungeon-Loot-1.14.x-(v.2.0.0).jar Customized Dungeon Loot {cdl@2.0.0 SIDED_SETUP} Waddles-1.14.4-0.8.3.jar Waddles {waddles@1.14.4-0.8.3 SIDED_SETUP} JustEnoughResources-1.14.4-0.10.0.63.jar Just Enough Resources {jeresources@0.10.0.63 SIDED_SETUP} mysticalworld-1.14.4-1.6.2.jar Mystical World {mysticalworld@1.14.4-1.6.2 SIDED_SETUP} forge-1.14.4-28.1.70-universal.jar Forge {forge@28.1.70 SIDED_SETUP} ruins-1.14.4.4.jar Ruins {ruins@1.14.3.3 SIDED_SETUP} Bones-1.14.4-1.3.1.jar Bones {bones@1.14.4-1.3.1 SIDED_SETUP} mysticallib-1.14.4-1.5.jar Mystical Lib {mysticallib@1.14.4-1.5 SIDED_SETUP} forge-1.14.4-28.1.70-client.jar Minecraft {minecraft@1.14.4 SIDED_SETUP} Craft_and_Hunt_V0.9.3_MC_1.14.4.jar Craft and Hunt {craftandhunt@0.4 SIDED_SETUP} pandoras_creatures-1.14.4-0.11.0.jar Pandoras Creatures {pandoras_creatures@1.14.4-0.11.0 SIDED_SETUP} AmbientSounds_v3.0.14_mc1.14.4.jar Ambient Sounds {ambientsounds@3.0.3 SIDED_SETUP} SilentLib-1.14.4-4.4.0+44.jar Silent Lib {silentlib@4.4.0+44 SIDED_SETUP} toughnessbar-4.0.jar Toughness Bar {toughnessbar@4.0 SIDED_SETUP} seafaring-1.14.4-0.1.46.jar Seafaring {sea@0.1.46 SIDED_SETUP} extcaves-1.3.3.jar Extended Caves {extcaves@1.3.3 SIDED_SETUP} Uncharted_1.14.4_v05.jar Uncharted {uncharted@v05 SIDED_SETUP} simplefarming-1.14.4-1.2.2.jar Simple Farming {simplefarming@1.14.4-1.2.2 SIDED_SETUP} GeneticAnimals_0_4_11.jar Genetic Animals {eanimod@0.4.11 SIDED_SETUP} villagesp_1.14-1.0.jar Village Spawn Point {villagesp@1.0 SIDED_SETUP} superslegend-1.01.jar Supers Legend {superslegend@1.01 SIDED_SETUP} lycanitesmobs-1.14.4-2.1.0.6.jar Lycanites Mobs {lycanitesmobs@1.0 SIDED_SETUP} whisperwoods-1.14.4-1.0.0.jar Whisperwoods {whisperwoods@1.0.0 SIDED_SETUP} curios-FORGE-1.14.4-1.0.5.jar Curios API {curios@FORGE-1.14.4-1.0.5 SIDED_SETUP} SpartanShields-1.14.4-2.0.0-beta-1.jar Spartan Shields {spartanshields@1.14.4-2.0.0-beta-1 SIDED_SETUP} corail_woodcutter-1.0.6-1.14.4.jar Corail Woodcutter {corail_woodcutter@1.0.6 SIDED_SETUP} SurvivalPlus-1.14.4-0.1.1.jar SurvivalPlus {survivalplus@0.1.1 SIDED_SETUP} BiomesOPlenty-1.14.4-9.0.0.255-universal.jar Biomes O' Plenty {biomesoplenty@1.14.4-9.0.0.254 SIDED_SETUP} themidnight-0.4.5.jar The Midnight {midnight@0.4.5 SIDED_SETUP} structurize-0.10.193-ALPHA.jar Structurize {structurize@0.10.193-ALPHA SIDED_SETUP} Enemyz-1.14.4-0.2.7.jar Enemyz {enemyz@0.2.7 SIDED_SETUP} worldedit-forge-mc1.14.4-7.0.1.jar WorldEdit {worldedit@7.0.1;61bc012 SIDED_SETUP} AppleSkin-mc1.14.4-forge-1.0.12.jar AppleSkin {appleskin@1.0.12 SIDED_SETUP} solcarrot-1.14.4-1.9.3.jar Spice of Life: Carrot Edition {solcarrot@1.14.4-1.9.3 SIDED_SETUP} Aquaculture-1.14.4-2.0.2.jar Aquaculture 2 {aquaculture@1.14.4-2.0.2 SIDED_SETUP} forgemod_VoxelMap-1.9.13b_for_1.14.4.jar VoxelMap {voxelmap@1.9.13 SIDED_SETUP} ScalingHealth-1.14.4-2.3.3+23.jar Scaling Health {scalinghealth@2.3.3+23 SIDED_SETUP} FastLeafDecay-v17.jar FastLeafDecay {fastleafdecay@v17 SIDED_SETUP} BetterAdvancements-1.14.4-0.1.0.92.jar Better Advancements {betteradvancements@0.1.0.92 SIDED_SETUP} Launched Version: forge-28.1.70 LWJGL: 3.2.2 build 10 OpenGL: Quadro 600/PCIe/SSE2 GL version 4.5.0 NVIDIA 369.09, NVIDIA Corporation GL Caps: Using GL 1.3 multitexturing. Using GL 1.3 texture combiners. Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported. Shaders are available because OpenGL 2.1 is supported. VBOs are available because OpenGL 1.5 is supported.

Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'forge'
Type: Client (map_client.txt)
Resource Packs: vanilla
Current Language: English (US)
CPU: 8x Intel(R) Xeon(R) CPU E31270 @ 3.40GHz`
itsmeow commented 4 years ago

Hmmm, my immediate thoughts are that another mod has a "wisp" particle in your pack. Do you have a pack zip / curseforge for your pack I can test with?

SirJamesalot commented 4 years ago

Hmmm, my immediate thoughts are that another mod has a "wisp" particle in your pack. Do you have a pack zip / curseforge for your pack I can test with?

That was my first thought too, but then i made a new forge profile with only whisperwoods, forge and vanilla MC and i get this:

`---- Minecraft Crash Report ---- // Uh... Did I do that?

Time: 10/28/19 2:59 PM Description: Rendering overlay

java.lang.IllegalStateException: Redundant texture list for particle whisperwoods:wisp at net.minecraft.client.particle.ParticleManager.func_215236_a(ParticleManager.java:201) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.particle.ParticleManager.lambda$null$0(ParticleManager.java:153) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.particle.ParticleManager$$Lambda$2429/833096840.run(Unknown Source) ~[?:?] {} at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1618) ~[?:1.8.0_51] {} at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1610) ~[?:1.8.0_51] {} at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) ~[?:1.8.0_51] {} at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) ~[?:1.8.0_51] {} at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1689) ~[?:1.8.0_51] {} at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) ~[?:1.8.0_51] {}

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head -- Thread: Client thread Stacktrace: at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:544)

-- Overlay render details -- Details: Overlay name: net.minecraft.client.gui.ResourceLoadProgressGui Stacktrace: at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:544) at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:890) at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:384) at net.minecraft.client.main.Main.main(SourceFile:155) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:56) at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$375/1800500978.call(Unknown Source) at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) at cpw.mods.modlauncher.Launcher.run(Launcher.java:81) at cpw.mods.modlauncher.Launcher.main(Launcher.java:65)

-- System Details -- Details: Minecraft Version: 1.14.4 Minecraft Version ID: 1.14.4 Operating System: Windows 10 (amd64) version 10.0 Java Version: 1.8.0_51, Oracle Corporation Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation Memory: 1048189368 bytes (999 MB) / 1372061696 bytes (1308 MB) up to 3008888832 bytes (2869 MB) CPUs: 8 JVM Flags: 5 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx3228m -Xms256m -XX:PermSize=256m ModLauncher: 4.1.0+62+5bfa59b ModLauncher launch target: fmlclient ModLauncher naming: srg ModLauncher services: /eventbus-1.0.0-service.jar eventbus PLUGINSERVICE /forge-1.14.4-28.1.70.jar object_holder_definalize PLUGINSERVICE /forge-1.14.4-28.1.70.jar runtime_enum_extender PLUGINSERVICE /accesstransformers-1.0.0-shadowed.jar accesstransformer PLUGINSERVICE /forge-1.14.4-28.1.70.jar capability_inject_definalize PLUGINSERVICE /forge-1.14.4-28.1.70.jar runtimedistcleaner PLUGINSERVICE /forge-1.14.4-28.1.70.jar fml TRANSFORMATIONSERVICE FML: 28.1 Forge: net.minecraftforge:28.1.70 FML Language Providers: javafml@28.1 minecraft@1 Mod List: forge-1.14.4-28.1.70-client.jar Minecraft {minecraft@1.14.4 SIDED_SETUP} forge-1.14.4-28.1.70-universal.jar Forge {forge@28.1.70 COMMON_SETUP} whisperwoods-1.14.4-1.0.0.jar Whisperwoods {whisperwoods@1.0.0 SIDED_SETUP} Launched Version: forge-28.1.70 LWJGL: 3.2.2 build 10 OpenGL: Quadro 600/PCIe/SSE2 GL version 4.5.0 NVIDIA 369.09, NVIDIA Corporation GL Caps: Using GL 1.3 multitexturing. Using GL 1.3 texture combiners. Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported. Shaders are available because OpenGL 2.1 is supported. VBOs are available because OpenGL 1.5 is supported.

Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'forge'
Type: Client (map_client.txt)
Resource Packs: 
Current Language: English (US)
CPU: 8x Intel(R) Xeon(R) CPU E31270 @ 3.40GHz`
FoxSamu commented 4 years ago

There is a forge event ParticleFactoryRegisterEvent which runs, as of forge 28.1, on the MOD event bus (not MinecraftForge.EVENT_BUS). When this event is called, you must register your particle factories to the ParticleManager.

There exists IParticleMetaFactory, which is a factory that creates the particle factory. When used for a specific particle, that particle is registered as having a JSON definition in assets/<modid>/particles/<particleID>.json. This file is a "particle list", and it determines which textures belong to a particle, and thus which textures to stitch on the particle texture map (particles are a texture map stitched from separate textures as of 1.14).

When that particle list is being loaded but the particle is not registered when the ParticleFactoryRegisterEvent is published, Minecraft sees this loading action as unnecessary as the specific particle does not subscribe for a texture list and it throws an exception... I'd have expected this to be a log message, but apparently it's a crash...

Again, it's necessary that you use the ParticleFactoryRegisterEvent, which runs right after the moment that vanilla registers their particle factories. Don't register in FMLClientSetupEvent, which is currently the case as I looked at the code.

itsmeow commented 4 years ago

@RedGalaxySoftware Oh thank you so much! I will fix this ASAP. I wasn't aware of this event, I was using client init! I don't know why it works on my machine but not on some other's. Well, thank you!

FoxSamu commented 4 years ago

In the IDE, it all works fine. But when you run from the launcher, it fails...

itsmeow commented 4 years ago

I did actually run it from the launcher before release, I have no idea why it worked!

FoxSamu commented 4 years ago

Threading issues... Loading is threaded from 1.14 so things load in more random order... If you're lucky it loads fine, other times it crashes...

itsmeow commented 4 years ago

Alright, @SirJamesalot, here you go! https://www.curseforge.com/minecraft/mc-mods/whisperwoods/files/2818094