Incompat with Better Animations Collection Mod - Githubissues

itsmeow / whisperwoods

Minecraft mod for Spooky Jam adding a few fearsome forest critters

Other

7 stars 10 forks source link

Incompat with Better Animations Collection Mod #33

Closed WenXin20 closed 2 years ago

WenXin20 commented 3 years ago

Describe the bug

This mod is incompatible with the Better Animations Collection mod.
When Whisperwoods is installed, an error is printed out to the logs.

To Reproduce Steps to reproduce the behavior:

Spawn spider and observe no new animations
Check logs for error

Log output/error

Error Log

Expected behavior

Spiders, pigs, squids, etc. should have extra animations.

Versions:

Forge v36.2.4
MC v1.16.5
Whisperwoods v2.0.2
Better Animations Collection v1.2b6

Additional Context

It is most likely related to the null in renders as as betteranimation goes and calls getModel(), then does stuff without checking if it is null https://github.com/itsmeow/whisperwoods/blob/12a05528149c9b3ff7eb101beb95738d0ae6a37f/src/main/java/dev/itsmeow/whisperwoods/client/renderer/entity/RenderWisp.java#L27
Pokecube had a similar incompat, which was able to be fixed by replacing the null in the render: https://github.com/Pokecube-Development/Pokecube-Issues-and-Wiki/commit/94a3292d7d358eff89f94c175976a0e7cec67ff7

itsmeow commented 3 years ago

Sure, but this isn't our bug. The mod should handle null models correctly when dealing with other mod's renderers.

WenXin20 commented 3 years ago

Yeah, which is why I made a report to Better Animations as well. I reported it here in case any changes had to be made.

WenXin20 commented 2 years ago

Fixed by Better Animations Collection mod :)