search

itsmeow / whisperwoods

Minecraft mod for Spooky Jam adding a few fearsome forest critters
Other
7 stars 10 forks source link

Include minecraft dependency definition in mods.toml #34

Closed Griefed closed 2 years ago

Griefed commented 3 years ago

Subject/Reason (Bug fix, new feature, etc.):

I noticed that your mods.toml is missing the dependency definition for Minecraft correlating to Whisperwoods Forge version.

mods.toml need to specify their sideness so Minecraft/Forge knows whether the mod needs to be available on the client, the server, or both. If a mod uses the modId for dependencies., it also helps with ServerPackCreator identifying clientside-only mods. Reference issue #70 of ServerPackCreator.

Let me know what you think. 👋

Cheers, Griefed

Legal Disclaimer: ANY PULL REQUEST SUBMITTED TO "The Project" (github.com/itsmeow/whisperwoods) AND MERGED INTO A RELEASED VERSION OF THE MODIFICATION (content released via CurseForge.com) BECOMES PROPERTY OF "THE OWNER" (its_meow and partner cybercat5555). ALL RIGHTS TO THE SUBMITTED CONTENT IS TRANSFERRED TO THE OWNER. Credit may or may not be given at The Owner's choice.

itsmeow commented 2 years ago

Sidedness is present now. Closing due to merge conflict.