nus-se-bot
commented
4 years ago Team's Response
Both the list and clear commands provided are correct commands that a user can enter, regardless of whether there are any flashcards in the list or not. Hence, we do not feel that there is a need to highlight the instructions red, unlike when the user is using a command in the wrong format, or an invalid command.
Furthermore, if the problem is merely that the command is not displayed in red, this should be considered a cosmetic flaw, hence I changed the severity to VeryLow.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: I think the team has a poor understanding of what should be considered as error thrown and what not. I think that list s/8 is a wrong command when set 8 is non existent in the application. This is because you are accessing a set which is not there. This is obviously a wrong command by user and wrong commands by users should have errors thrown as the textbook mentions under the section of Assertions -> When. Furthermore, another similar command view 4 throws an error as shown below when 4 is not a flashcard there. If this is treated as an error but not the list s/8 is extremely confusing. Hence, their justification that it is not in the wrong format does not stand here, because in one case it is treated as a format error(view) but not in another(list). Therefore, this is an obvious bug.
:question: Issue severity
Team chose [severity.VeryLow]
Originally [severity.High]
- [x] I disagree
Reason for disagreement: Again the severity VeryLow should only be used for bugs caused by typo or cosmetic flaw, this is not a typo. This is a serious flaw in the product itself as the reason why the "error" is in black is because it is not treated as an exception in the first place. A user command with a problem that is unable to give the desired output should be treated as an exception. Hence, this confuses the user as to whether their command is correct or not. As sometimes error is given in black and sometimes in red. When given in black the user may not aware that it is an error, hence it is a big problem for users and thus severity is high.
In previous commands when there is an error in command line instrcution, it is marked in red, however when the following CLI is used: list s/8
Message given is not error message as it is in black. Therefore, it is probbaly not treated as an error message.