search

itsthatguy / avatars-api-middleware

The express middleware for our avatars service
http://avatars.adorable.io
Other
749 stars 96 forks source link

Add size parameter to Custom Face Parts endpoint #41

Closed Joeao closed 6 years ago

Joeao commented 8 years ago

Hi,

I was hoping to make a pull request myself but am having trouble installing the project locally. Would it be possible to add a size parameter to the end of the Custom Face Parts endpoint? I think the endpoint is particularly useful in its flexibility, other than not being able to append a size. It looks as though it would entail the following changes:

router.get '/face/:eyes/:nose/:mouth/:color/:size', (req, res, next) -> // @/lib/routes/v2.coffee:34

imager.combine faceParts, req.params.size, (err, stdout) -> // @/lib/routes/v2.coffee:50

But without being able to test it myself, it's possible that the task is larger.

Thanks for your work on the project, I like it.

aiobot commented 8 years ago

Can you explain the issues you’re having locally? It’s very important to us that users are able to easily install avatars, and submit PRs.

Joeao commented 8 years ago

Sure. On reflection, I probably should have started there. Will open a new issue and come back to this later.

ajklinger1 commented 6 years ago

Is there anyway to unsubscribe me to receiving adoble github emails?

On Mon, Apr 9, 2018, 11:47 AM Ryland Herrick notifications@github.com wrote:

Closed #41 https://github.com/adorableio/avatars-api-middleware/issues/41 via c49183e https://github.com/adorableio/avatars-api-middleware/commit/c49183e834867b821b1ad5118e1ea2e5f0d58818 .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/adorableio/avatars-api-middleware/issues/41#event-1564291528, or mute the thread https://github.com/notifications/unsubscribe-auth/ARcOVIkCi4J8vi6hQsn8hRLnBUTYoECfks5tm5CXgaJpZM4HovR3 .

rylnd commented 6 years ago

@ajklinger1 you can choose to stop watching this repository by clicking 'Unwatch' at the top of the page. You can also manage your general Notifications settings on the Profile > Settings > Notifications page.