search

itsthatguy / avatars-api-middleware

The express middleware for our avatars service
http://avatars.adorable.io
Other
749 stars 96 forks source link

The server code is meant to be only for testing/development #91

Closed itsthatguy closed 5 years ago

itsthatguy commented 5 years ago

@rylnd Does this address your request in #90?

rylnd commented 5 years ago

@itsthatguy it's a good start. I assume that you moved the server file out of src/ so that it wouldn't be transpiled to dist/, but it's a bit weird for the target of dev:server to live in the test/ folder. I think that moving server.js to the root would be a bit less surprising and would accomplish the same goals, but that's a guess that needs verification.

itsthatguy commented 5 years ago

@rylnd I moved it to test/ to very clearly communicate that it only exists for testing purposes. (both programmatic, and human testing)

rylnd commented 5 years ago

Fair enough! I'm down with that.

The only outstanding thing I see, then, are references to our old heroku deployment stuff:

I'm happy to remove those quick, or you can; lemme know.

itsthatguy commented 5 years ago

@rylnd DONE!

rylnd commented 5 years ago