Replace Babel with Typescript

itsthatguy / avatars-api-middleware

The express middleware for our avatars service

http://avatars.adorable.io

Other

749 stars 96 forks source link

Replace Babel with Typescript #93

Closed rylnd closed 5 years ago

rylnd commented 5 years ago

Just an FYI for @itsthatguy; I'm working on addressing #92 by moving over to typescript. Looking over this code I think that ~95% of it is going to change, but I'm going to try and do the migration incrementally.

Goals

Update dependencies
Replace babel with typescript
Don't change the API
Don't change how we hash things
[x] remove babel
[x] upgrade everything to latest
[x] add typescript
[x] reimplement build/publish process with typescript
[x] add types
[x] refactor

rylnd commented 5 years ago

@itsthatguy I published an alpha release (0.2.2-alpha.0) of the typescript branch to verify that stuff still works; the only issue right now is that I've reintroduced #86 by switching to typescript. Gotta do some googling and see if there's an easy fix. Otherwise, things are looking good!

rylnd commented 5 years ago

I also removed the server code from being published, so it'll be impossible for consumers of the module to run the server (which should hopefully lessen the confusion of #91 )

rylnd commented 5 years ago

@itsthatguy here's a diff without #94 : DIFF