adding file icons form DC theme

itsthatguy / theme-itg-flat

A flat theme for Sublime Text that supports both retina and non-retina.

480 stars 56 forks source link

adding file icons form DC theme #45

Closed orizens closed 9 years ago

orizens commented 9 years ago

Also, added 2 new settings to allow:

hiding tree folders
hiding file icons in tree
Example:

baaboum commented 9 years ago

Hello, thanks to work for add icons file on sidebar :) . if it's possible, how can i see your work on sublimetext 3 ?

orizens commented 9 years ago

hi @baaboum thanks. what do you mean by "see your work on sublimetext 3"?

itsthatguy commented 9 years ago

This is cool. The icons don't fit the theme, however. I'd love to see a collection of white icons that fit the theme, and can be colored programmatically! Great work!

mavinger commented 9 years ago

@itsthatguy I am not familiar with coding themes for Sublime. Is programmatically color coding the sidebar icons possible?

itsthatguy commented 9 years ago

@venetianthief I would think so. You could try using "layer0.tint": [255, 255, 255, 200] on the element that has the icon. icons are supposed to set the layer0.texture

mavinger commented 9 years ago

@itsthatguy coooool! I will try to poke around this weekend and see if I can get it working.

jchannon commented 9 years ago

I'd like icons! I have downloaded @orizens repo and I'm using that :smile:

itsthatguy commented 9 years ago

@orizens can you resubmit using the new development environment and:

file icons setting should default to hidden
update readme to explain how to enable the file icons

I'd love to get this in, but merging now will break master... And not persist through future changes

orizens commented 9 years ago

@itsthatguy how do i pull the latest changed from your repo?

jchannon commented 9 years ago

in your local git repo do

git remote add upstream https://github.com/itsthatguy/theme-itg-flat.git
git checkout master
git pull upstream master
git checkout -b myiconbranch

make your changes

git push origin myiconbranch -- this assumes origin is your fork of this repo

Open a PR :smile:

orizens commented 9 years ago

@jchannon thanks.
did it :)

jchannon commented 9 years ago

no probs :)

On 17 April 2015 at 17:38, Oren Farhi notifications@github.com wrote:

@jchannon https://github.com/jchannon thanks.

did it :)

Reply to this email directly or view it on GitHub https://github.com/itsthatguy/theme-itg-flat/pull/45#issuecomment-94023425 .

EmmanuelBeziat commented 9 years ago

Hi @orizens I did try to use your version, but i'm facing this little problem here :

What's the matter ? I've just put the folder of your fork in my Package files, renamed it correctly, used it and... There.

Thanks !

orizens commented 9 years ago

hi @EmmanuelBeziat . I stopped maintaining it. It doesn't work for me either.

itsthatguy commented 9 years ago

I believe there was an update to icons in ST3 that needs to be addressed