search

itswadesh / svelte-commerce

The open-source storefront for any ecommerce. Built with a PWA and headless approach, using a modern JS stack. Works with Litekart, Medusa. WIP for Woocommerce, Bigcommerce and Shopify.
https://arialshop.com
MIT License
1.55k stars 295 forks source link

Fix reel video page #68

Closed itswadesh closed 11 months ago

raunakhajela commented 1 year ago

Could you please share more info on what issue we talking about here?

itswadesh commented 1 year ago

Hi @raunakhajela This issue here is about fixing the following page, it has some UX issues

https://demo.litekart.in/reel

leorsousa05 commented 1 year ago

I oppened a pull request for it: #76

leorsousa05 commented 1 year ago

I think it's just close this issue. The #76 already fix with the new icons and setup, the only thing needed to finish is approving the other check.

itswadesh commented 1 year ago

@leorsousa05 Thank you so much for fixing icons. Looks fine now. Can you please help me fixing the video player issue,

  1. The video that is in view must play and all other must stop.
  2. The mute button functionality
leorsousa05 commented 1 year ago

No problem :), i'll try to do it, i'll open a pull request with it

leorsousa05 commented 1 year ago

Hey @itswadesh i also found out that the videos doesn't have audio. You have the videos with audio?

itswadesh commented 11 months ago

The reels module is now working fine. Hence closing it.