itswebny / universal-navigation

Guidance and implementation instructions relating to the Universal Navigation (formerly NYS Common Web Banner) deployment.
24 stars 10 forks source link

Issues with News formatting #114

Open Lukenickerson opened 9 years ago

Lukenickerson commented 9 years ago

Success Criteria

Clicking Save to My Services works (it does get saved), but there is no indication to the used that it has been saved. And the Saved notice is always shown.

Tested on http://qaapps.cio.ny.gov/apps/mediacontact/public/ w/ Chrome -- click News

image

gingerg commented 9 years ago

I just came across this same issue this morning on http://archive.governor.ny.gov/EmergencyPreparednessCommissions and http://archive.governor.ny.gov/puttingstudentsfirst (PC Chrome latest) emerg-prep

lukecharde commented 9 years ago

All issues that have come in since last group review are being removed from "NY.GOV Launch - Development" milestone until full consensus on issue/solution/milestone is determined.

Contributing.md has been updated: https://github.com/nys-its/universal-navigation/blob/gh-pages/contributing.md#milestones

sbrewster commented 9 years ago

@Lukenickerson please re-test, update was pushed at end of last week

gingerg commented 9 years ago

:+1: the text in question no longer appears at all, that's solved! :)

lzuker commented 9 years ago

Looks like the image broke again. (On Desktop) http://archive.governor.ny.gov/puttingstudentsfirst http://qaapps.cio.ny.gov/apps/mediacontact/public/ image

mandyparker commented 9 years ago

The text in question is still there and is simply fully obscured (depending on resolution) as it has the same text color as the h2 background. With the buttons to view all content at the bottom of the panes, is it necessary to have them at the top as well?

Goldieashe commented 9 years ago

Based on viewing archive.governor.ny.gov, http://nys-its.github.io/universal-navigation/demos/interactive-option-demo.html and http://qaapps.cio.ny.gov/apps/mediacontact/public/ the three criteria at top seem to have been met:

lzuker commented 9 years ago

I'm seeing the same thing on Firefox.The image just needs a height of auto. image

Lukenickerson commented 9 years ago

Image is still distorted on http://nys-its.github.io/universal-navigation/demos/interactive-option-demo.html and http://programs.governor.ny.gov/puttingstudentsfirst

image image

...but looks good on ny.gov...

image

ny.gov does not have a data-updated attribute, so I'm not sure if they'r using the same version or not.