ittiam-systems / libmpegh

MPEG-H 3D Audio Low Complexity Profile Decoder. Encoder: https://github.com/ittiam-systems/libmpeghe
http://www.ittiam.com/
BSD 3-Clause Clear License
88 stars 18 forks source link

Browser plug-in demo added #14

Closed SakethSathuvalli closed 2 years ago

SakethSathuvalli commented 2 years ago

[x] A demo of MPEG-H 3D Audio decoder integrated into browsers is added. [x] User guide document for the demo is added. [x] Limitations of the demo:

christof-fersch commented 2 years ago

Hi!

I left one proposed change to the readme in a patch and created a PR. It is about changing the following sentence: "A demonstartion of integrating the MPEG-H 3D Audio decoder to browsers is added." -> "A demonstration of how the MPEG-H 3D Audio decoder may be integrated and used in browsers is added."

In addition, could we add MacOS to the "2.1 Installation Overview" in IA-MPEG-H-3D-Audio-Dec-Browser-Plugin-UG.doc? I have tested this and it works similarly.

Thanks, //Christof

SakethSathuvalli commented 2 years ago

Hi!

I left one proposed change to the readme in a patch and created a PR. It is about changing the following sentence: "A demonstartion of integrating the MPEG-H 3D Audio decoder to browsers is added." -> "A demonstration of how the MPEG-H 3D Audio decoder may be integrated and used in browsers is added."

In addition, could we add MacOS to the "2.1 Installation Overview" in IA-MPEG-H-3D-Audio-Dec-Browser-Plugin-UG.doc? I have tested this and it works similarly.

Thanks, //Christof

Thanks for the feedback!

We have addressed this in the commit - 1a0119475fbdd141f82ba554709dc839c3e8ecd6