Closed sclsj closed 9 months ago
Hi @sclsj,
Can You please let us know if the decode failure happens with our latest commit - 3b23f65 ?
Thanks!
Hi @sclsj,
I was wondering if You got a chance to try decoding the files with our latest commit!
Yep, still the same problem (error output) with freshly cloned and built project.
With that being said, I'm doing autoreconf -i ; ./configure; make
to build the project. It seems like I can also build the project using cmake (which I tried; it gave an error, see below) or the makefile in build/make
(which I tried before successfully, but I don't remember how I did it)? Is there any difference between these three way of compiling?
Cmake error (`mkdir buildnew ; cd buildnew ; cmake ../)
make
[ 0%] Building C object CMakeFiles/ia_mpeghd_lib.dir/decoder/impd_drc_dynamic_payload.c.o
[ 1%] Building C object CMakeFiles/ia_mpeghd_lib.dir/decoder/impd_drc_extr_delta_coded_info.c.o
[ 2%] Building C object CMakeFiles/ia_mpeghd_lib.dir/decoder/impd_drc_filter_bank.c.o
In file included from /Users/jin/libmpeghnew/decoder/impd_drc_filter_bank.c:36:
/Users/jin/libmpeghnew/decoder/impeghd_type_def.h:55:13: error: typedef redefinition with different types ('int' vs '__darwin_intptr_t' (aka 'long'))
typedef int intptr_t;
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/include/sys/_types/_intptr_t.h:32:33: note: previous definition is here
typedef __darwin_intptr_t intptr_t;
^
1 error generated.
make[2]: *** [CMakeFiles/ia_mpeghd_lib.dir/decoder/impd_drc_filter_bank.c.o] Error 1
make[1]: *** [CMakeFiles/ia_mpeghd_lib.dir/all] Error 2
make: *** [all] Error 2
Hi @sclsj,
We follwed the steps provided here and the build was successful on macOS. Can You provide details about Cmake version you used and the compiler you are using ?
cmake --version
cmake version 3.25.1
CMake suite maintained and supported by Kitware (kitware.com/cmake).
cmake ../ -DBUILD_SHARED_LIBS=OFF -DCMAKE_BUILD_TYPE=RELEASE
-- The C compiler identification is AppleClang 13.1.6.13160021
-- The CXX compiler identification is AppleClang 13.1.6.13160021
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/jin/libmpegh_compileerror/bin
cc --version
Apple clang version 13.1.6 (clang-1316.0.21.2.5)
Target: arm64-apple-darwin21.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
c++ --version
Apple clang version 13.1.6 (clang-1316.0.21.2.5)
Target: arm64-apple-darwin21.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
Also tried with gcc
version 12.2.0 installed with homebrew:
export CC=/opt/homebrew/bin/gcc-12
export CXX=/opt/homebrew/bin/g++-12
cmake ../
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- Checking whether C compiler has -isysroot
-- Checking whether C compiler has -isysroot - yes
-- Checking whether C compiler supports OSX deployment target flag
-- Checking whether C compiler supports OSX deployment target flag - yes
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /opt/homebrew/bin/gcc-12 - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Checking whether CXX compiler has -isysroot
-- Checking whether CXX compiler has -isysroot - yes
-- Checking whether CXX compiler supports OSX deployment target flag
-- Checking whether CXX compiler supports OSX deployment target flag - yes
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/homebrew/bin/g++-12 - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/jin/libmpegh_compileerror/bin
Got the same error with make
.
Apparently by commenting out that line (55) the program is able to compile. I'm not sure if that causes any unexpected behaviors, but it seems like the executable works and passed the smoke test provided.
Hello.
For your reference, I cloned the latest repo and compiled again using autoreconf and saw no errors.
Hello, this issue might be a duplicate of #54. Let me know if I should close this issue.
Hi @sclsj,
The fix for #54 is available on latest main now. Please try latest main build once.
Thanks!
Closing due to no activity since long time.
https://user-images.githubusercontent.com/38654636/197081283-2ca03631-90e2-4786-9d47-06e1cc453748.mp4
https://user-images.githubusercontent.com/38654636/197081284-fddf2f77-b06d-40e5-a56d-34149613749a.mp4
Source file: MPF.wav.zip ADM.wav.zip
Source object produced by
sox -v 0.50 -n -r 48k -b 16 -c 1 1.wav synth 10 sin 120
. Source file produced by trial with MPEG-H Authoring Tool working. Encoded mp4 produced by MPEG-H EncMux. The latter two comes from "the MPEG-H Authoring Suite 5.0 which is available for free here: https://www.iis.fraunhofer.de/en/ff/amm/dl/software/mas.html"