ittiam-systems / libmpegh

MPEG-H 3D Audio Low Complexity Profile Decoder. Encoder: https://github.com/ittiam-systems/libmpeghe
http://www.ittiam.com/
BSD 3-Clause Clear License
88 stars 18 forks source link

Add Support For Deezer 360 #7

Closed k-popfilters closed 1 year ago

k-popfilters commented 2 years ago

i keep on getting a blinking cursor when using deezer 360 files

SakethSathuvalli commented 2 years ago

Can You please provide more details about the issue ? Also will it be possible for You to share the stream with us ?

Thanks!

k-popfilters commented 2 years ago

yes yes i will send you guys the stream https://drive.google.com/file/d/1NOnczYBfMZtp0Cs_ll43B9suRuz-fRut/view?usp=sharing

k-popfilters commented 2 years ago

just hangs there been waiting for like 20 minutes nothing is happening

k-popfilters commented 2 years ago

after an hour i got this after an hour of waiting i got this

SakethSathuvalli commented 2 years ago

Hello,

The file You shared is of profile level 4. Our decoder supports only up to profile level 3 and hence the decode failure is reported.

We have another open issue and we have specified a workaround. Please refer to the link below: https://github.com/ittiam-systems/libmpegh/issues/1#issuecomment-1064887503

Please follow the instructions in this link and try decoding once. We tried with this at our end and we are able to successfully decode the file You shared.

Thanks!

k-popfilters commented 2 years ago

oh yes thank you i will try it:)

k-popfilters commented 2 years ago

Hello,

The file You shared is of profile level 4. Our decoder supports only up to profile level 3 and hence the decode failure is reported.

We have another open issue and we have specified a workaround. Please refer to the link below: #1 (comment)

Please follow the instructions in this link and try decoding once. We tried with this at our end and we are able to successfully decode the file You shared.

Thanks!

wait what do you mean by comment line 1483?

SakethSathuvalli commented 2 years ago

Hello, The file You shared is of profile level 4. Our decoder supports only up to profile level 3 and hence the decode failure is reported. We have another open issue and we have specified a workaround. Please refer to the link below: #1 (comment) Please follow the instructions in this link and try decoding once. We tried with this at our end and we are able to successfully decode the file You shared. Thanks!

wait what do you mean by comment line 1483?

Please check the link below for the exact line:

https://github.com/ittiam-systems/libmpegh/blob/main/decoder/ia_core_coder_init_config.c#L1483

Comment this line and rebuild the executable.

k-popfilters commented 2 years ago

yes i have that line

k-popfilters commented 2 years ago

Hello, The file You shared is of profile level 4. Our decoder supports only up to profile level 3 and hence the decode failure is reported. We have another open issue and we have specified a workaround. Please refer to the link below: #1 (comment) Please follow the instructions in this link and try decoding once. We tried with this at our end and we are able to successfully decode the file You shared. Thanks!

wait what do you mean by comment line 1483?

Please check the link below for the exact line:

https://github.com/ittiam-systems/libmpegh/blob/main/decoder/ia_core_coder_init_config.c#L1483

Comment this line and rebuild the executable.

nope still does the same blinking cursor

SakethSathuvalli commented 2 years ago

Code Commenting CodeCommenting

Rebuild the executable

Console log screenshot

consoleLog

k-popfilters commented 2 years ago

it worked thank you!

k-popfilters commented 2 years ago

i also got a fatal error

k-popfilters commented 2 years ago

2 1 with this track https://drive.google.com/file/d/19SAMQdGH5cmL7YVM0X2mR0iSLr7ZhAgo/view?usp=sharing

SakethSathuvalli commented 2 years ago

2 1 with this track https://drive.google.com/file/d/19SAMQdGH5cmL7YVM0X2mR0iSLr7ZhAgo/view?usp=sharing

Hi,

A preliminary look at the decode failure(after 5678 frames) of the file "01 - Love Me Land.mp4" gave us an impression that the file does not comply with MPEG-H low complexity encoding specifications. One such deviation from the MPEG-H low complexity profile restrictions is below:

The file's sampling frequency is 48000 Hz and it uses LPD mode of encoding. According to the MPEG-H standard LPD mode is supported only for sampling frequencies <= 32000 Hz. The decoder is reporting an error on encountering such frame (Frame No: 5679) and as a result fails to decode further.

Will it be possible for You to share the source/mechanism used for creating this file? This can probably help us suggest You any option for encoding / recreating the file in decodable format.

Thanks!

k-popfilters commented 2 years ago

I used deemix to get the songs

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Saketh Sathuvalli @.> Sent: Thursday, June 23, 2022 5:13:58 AM To: ittiam-systems/libmpegh @.> Cc: k-popfilters @.>; Author @.> Subject: Re: [ittiam-systems/libmpegh] Add Support For Deezer 360 (Issue #7)

[2]https://user-images.githubusercontent.com/105951186/175106120-5fe19d17-4999-49a7-bc2f-c5839df1781a.PNG [1] https://user-images.githubusercontent.com/105951186/175106125-68bab325-d8d4-45db-8074-cfec440c36c7.PNG with this track https://drive.google.com/file/d/19SAMQdGH5cmL7YVM0X2mR0iSLr7ZhAgo/view?usp=sharing

Hi,

A preliminary look at the decode failure(after 5678 frames) of the file "01 - Love Me Land.mp4" gave us an impression that the file does not comply with MPEG-H low complexity encoding specifications. One such deviation from the MPEG-H low complexity profile restrictions is below:

The file's sampling frequency is 48000 Hz and it uses LPD mode of encoding. According to the MPEG-H standard LPD mode is supported only for sampling frequencies <= 32000 Hz. The decoder is reporting an error on encountering such frame (Frame No: 5679) and as a result fails to decode further.

Will it be possible for You to share the source/mechanism used for creating this file? This can probably help us suggest You any option for encoding / recreating the file in decodable format.

Thanks!

— Reply to this email directly, view it on GitHubhttps://github.com/ittiam-systems/libmpegh/issues/7#issuecomment-1163907219, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZIK7UVHDWFDAWUSWHPSRKTVQPQANANCNFSM5ZQGFMWQ. You are receiving this because you authored the thread.Message ID: @.***>

SakethSathuvalli commented 1 year ago

Closing the issue as cause was explained.