ittybittyapps / appstoreconnect-cli

An easy to use command-line tool for interacting with the Apple AppStore Connect API

MIT License

173 stars 17 forks source link

Implement ListDownloadCertificate Command #118

Closed DechengMa closed 4 years ago

DechengMa commented 4 years ago

This PR is to Implement the list and download certificates feature. Closes issue #86

📝 Summary of Changes

Changes proposed in this pull request:

Add serialNumber to model Certificate
Create ListCertificatesOptions and ListCertificatesOpertaion
Implement ListDownloadCertificates, support viewing and downloading certificates

🧐🗒 Reviewer Notes

💁 Example

Usage: asc certificates list [--filter-serial <filter-serial>] [--sort <sort>] [--filter-type <filter-type>] [--filter-display-name <filter-display-name>] [--limit <limit>] [--download-path <download-path>]

Sample output:

without download file path:

SerialNumber	Name	Display Name	Platform	Type	Expiration Date
XXXYY	iOS Development: Created via API	Something	IOS	IOS_DEVELOPMENT	2021-04-22 01:23:45 +0000

with download file path:

`📥 Certificate 'iOS Development: Created via API' downloaded to: /Documents/github/XXXYY.cer`	SerialNumber	Name	Display Name	Platform	Type	Expiration Date
XXXYY	iOS Development: Created via API	Something	IOS	IOS_DEVELOPMENT	2021-04-22 01:23:45 +0000

🔨 How To Test

swift run asc certificates list

swift run asc certificates list --download-path ~/Documents/github

orj commented 4 years ago

This is looking good @DechengMa, just some minor changes would make it 💯