ittybittyapps / appstoreconnect-cli

An easy to use command-line tool for interacting with the Apple AppStore Connect API
MIT License
175 stars 17 forks source link

Remove Dependencies pattern in favour of using requestors #127

Closed adamjcampbell closed 4 years ago

adamjcampbell commented 4 years ago

This is an attempt to make things simpler with a Requestor interface rather than defining dependencies per operation

📝 Summary of Changes

Changes proposed in this pull request:

⚠️ Items of Note

There are some generic casting dances that need to happen to support testing. However the operation code has become cleaner as a result. The requestor can be passed to all operations without needing to create multiple different kinds of dependencies.

🧐🗒 Reviewer Notes

Please provide any thoughts / feedback on this change