ittybittyapps / appstoreconnect-cli

An easy to use command-line tool for interacting with the Apple AppStore Connect API
MIT License
173 stars 17 forks source link

Bug/add pagination to operations #165

Closed DechengMa closed 4 years ago

DechengMa commented 4 years ago

Closes #92

📝 Summary of Changes

Changes proposed in this pull request:

Add pagination to

🧐🗒 Reviewer Notes

Please point out if there are any operations that need pagination, if there are not included in this PR :)

Problems:

This might break command line option:--limit. Can do some validation for option.limit is nil or not, then determine if pagination should be done or not.

🔨 How To Test

swift run asc certificates list swift run asc testflight prereleaseversion list swift run asc users list

orj commented 4 years ago

@DechengMa I think the full list of paginated responses is:

orj commented 4 years ago

@DechengMa please make sure pagination is applied to all the places it makes sense before closing #92