ittybittyapps / appstoreconnect-cli

An easy to use command-line tool for interacting with the Apple AppStore Connect API

MIT License

173 stars 17 forks source link

Bug: Running `asc bundle-ids list` #193

Closed raven closed 4 years ago

raven commented 4 years ago

🌎 Environment

OS: macOS
Version/Release: 0.1.0

💬 Description

Running asc bundle-ids list fails after some significant amount of delay.

asc users succeeds speedily ~3seconds

🦶 Reproduction Steps

asc bundle-ids list

🤔 Expected Results

A list of bundle ids

😲 Actual Results

After ~3mins20sec of non-responsiveness, macOS killed it with bus error

$ time asc bundle-ids list
[2]    21383 bus error  asc bundle-ids list
asc bundle-ids list  10.57s user 0.59s system 5% cpu 3:19.87 total

I can see whilst I am running asc that it is utilising networking:

🌳 Logs

Where might I find those?

raven commented 4 years ago

Tell me what you need to help diagnose 👍

orj commented 4 years ago

@raven Can you run it in Xcode and see where it is getting caught up. I have a feeling it is awaiting on results and not getting anything or getting stuck in a loop.

orj commented 4 years ago

@raven also please try other commands to see if you get any similar issues.

What role did you give your API Key?

adamjcampbell commented 4 years ago

I also think it is most likely an issue with some output getting swallowed in a publisher chain and waiting on await.

The default timeout is .distantFuture but maybe it shouldn't be? https://github.com/ittybittyapps/appstoreconnect-cli/blob/d8faf3989f55909d9b399576fbc348450a7d4137/Sources/AppStoreConnectCLI/Helpers/Publisher%2BHelpers.swift#L24

raven commented 4 years ago

What role did you give your API Key

developer

also please try other commands to see if you get any similar issues.

✅ asc users
✅ asc certificates list
❌ asc devices list

✅ ❌ asc profiles list ( wow that was some output that flew past )

Exited with 1 status code

This failed differently than the original issue. The output streamed past, and then ended with:

Error: dataCorrupted(Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "included", intValue: nil), _JSONKey(stringValue: "Index 366", intValue: 366), CodingKeys(stringValue: "attributes", intValue: nil), CodingKeys(stringValue: "certificateType", intValue: nil)], debugDescription: "Cannot initialize CertificateType from invalid String value DEVELOPMENT", underlyingError: nil)).

✅ asc testflight apps list
✅ asc testflight builds list took a very long time to complete (3164 builds)

raven commented 4 years ago

Would be great if there was some kind of messaging to stderr "This can take a long time..." or some other cli ux that indicated activity (--verbose, ncurses etc).

orj commented 4 years ago

@raven Thanks for giving this a whirl Pete. Much appreciated.

DechengMa commented 4 years ago

As https://github.com/AvdLee/appstoreconnect-swift-sdk/pull/111 was merged this issue should be fixed. See #207

raven commented 4 years ago

Will there be a release to accomodate this fix?