ittybittyapps / appstoreconnect-cli

An easy to use command-line tool for interacting with the Apple AppStore Connect API
MIT License
172 stars 17 forks source link

Change ListProfilesByBundleIdCommand to use fuzzy search #235

Closed DechengMa closed 3 years ago

DechengMa commented 3 years ago

Remove bundle id must be unique validation for ListProfilesByBundleIdCommand. Input first part of the bundle ID will result in all the matched cases.

📝 Summary of Changes

Changes proposed in this pull request:

⚠️ Items of Note

Inputted bundle Id string must be the first part of the bundle Id.

🧐🗒 Reviewer Notes

💁 Example

USAGE:

asc profiles list-by-bundle [--api-issuer <uuid>] [--api-key-id <keyid>] [--csv] [--json] [--table] [--yaml] [--verbose] <bundle-id> [--limit <limit>] [--download-path <path>]

🔨 How To Test

swift run asc profiles list-by-bundle com --download-path ../../
orj commented 3 years ago

If you could update the documentation on the list-by-bundle command too to reflect the change in behaviour. That would be great.

DechengMa commented 3 years ago

If you could update the documentation on the list-by-bundle command too to reflect the change in behaviour. That would be great.

Cool, will do, what do you think of this?

abstract: "Find and list provisioning profiles and download their data by performing a fuzzy search for bundleId.",
orj commented 3 years ago

I think the behaviour should be slightly different too. I think it should only match the beginning of the bundle ID. We'll have to do some local filtering for that.

orj commented 3 years ago

I think the abstract is ok as is. I think we should add further discussion to the bundleId argument:

@Argument(help: "The bundle ID of an application. (eg. com.example.app)",
              discussion: "Note that all provisioning profiles for bundle identifiers beginning with this string will be fetched.")
    var bundleId: String