ittybittyapps / appstoreconnect-cli

An easy to use command-line tool for interacting with the Apple AppStore Connect API

MIT License

172 stars 17 forks source link

Add pretty flag to CommonOptions #240

Closed DechengMa closed 3 years ago

DechengMa commented 3 years ago

This PR is for adding pretty flag to input options for closing #221

📝 Summary of Changes

Changes proposed in this pull request:

Create OutputOptions and wrap existing output-related input options.
Create ResultRendererWithOptions for taking options
Update renderAsJSON function to taking pretty flag.

⚠️ Items of Note

This PR is a draft, more changes will come if this PR gets approved.

Planed changes

Remove outputFormat, printLeve and verbose in CommonOptions
Replace ResultRenderer with ResultRendererWithOptions
Update all the existing commands for adaptation.

🧐🗒 Reviewer Notes

💁 Example

Usage:

asc certificates list <options>

--pretty                Display result in a human readable format.

🔨 How To Test

swift run asc certificates list --json --pretty

DechengMa commented 3 years ago

LGTM

Hi @orj , thanks for the review, I just pushed the planned changes for updating all the existing command to adapt, could you please take a look again? Thanks!