ituob / itu-ob-editor

Cross-platform desktop application for collaborative editing of ITU Operational Bulletin data
6 stars 3 forks source link

Run own CORS proxy for Git interaction #8

Open strogonoff opened 5 years ago

strogonoff commented 5 years ago

The way isomorphic-git works, it requires a proxy to clone and push repositories purely in-browser (allowing for a purely Electron app that doesn’t bring any OS dependencies with it).

isomorphic-git maintainers run a proxy of their own, which we are using for now. However, using a third-party proxy poses a security risk (especially with basic HTTP auth if we use it), and there is no guarantee for its uptime (if it goes down, it would break ITU OB editing workflow).

We could / should bring up a proxy of our own, either on Ribose or ITU OB behalf, using the proxy server package open-sourced by isomorphic-git team. If we run it on Ribose’s behalf, we could probably reuse the same proxy with ITU-unrelated static site editor apps (if we end up having those).

CC @ronaldtse—this may or may not be critical for first beta release of the app to actual ITU OB editors.

It is possible that proxy will be runnable on Lambda without much extra work, or otherwise the smallest possible instance should be more than enough.