search

itzblim / pe

0 stars 0 forks source link

Error messages for edit command for large number indices are sometimes not specific #4

Open itzblim opened 3 years ago

itzblim commented 3 years ago

Steps to reproduce:

  1. Type in "edit 2000000000000000 qn/test

When the index is within the range of an integer, the error correctly specifies: image.png

However, when the index is out of range of an integer, the error displayed is: image.png The same error is used for other incorrect parameters: image.png and the user isn't specifically told that the problem is the large number.

nus-pe-bot commented 2 years ago

Team's Response

Thank you for your report. We will be rejecting this due to the following reason:

This is the edit command documentation in the User Guide, which clearly specifies what a valid index is.

Screenshot 2021-11-13 140817.png

Furthermore, when running edit 20000000000000000 qn/test , the error message as displayed by SmartNus also specifies the limitations on the INDEX by specifying the range.

Relevant statement from the error message: Parameters: INDEX (must be a positive integer between 1 and 2147483647 both inclusive)

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Agree that the documentation is clear in the User Guide.

However, error messages should tell the user what was typed wrongly, rather than display the generic command usage message.

Your team tells the user the problem in some cases, but not all (as seen in the screenshots).