itzg / docker-mc-backup

Provides a side-car container to backup itzg/minecraft-server world data
https://hub.docker.com/r/itzg/mc-backup
MIT License
316 stars 52 forks source link

Is it possible that excluding files of type .jar could potentially lead to unexpected issues? #162

Closed Kagenui-yozuru closed 9 months ago

Kagenui-yozuru commented 9 months ago

I've observed that the default value of the EXCLUDES environment variable is *.jar,cache,logs,*.tmp, which excludes all .jar files. Could this lead to unexpected situations? In my server, I have installed mods (which are all .jar files), and using the default EXCLUDES configuration would result in the mods within the mods/ folder not being backed up, causing issues when restoring the server and preventing it from starting properly. Additionally, there are other jar files outside the mods/ folder whose purposes I am unaware of, although they do consume a significant amount of space. Considering a better approach to exclude jar files other than those in the mods/ folder, would it be worth considering an upgrade to the exclusion strategy? For example, supporting the following format: EXCLUDES=*.jar,!mods/*.jar.

itzg commented 9 months ago

That is only the default. You can override it with the patterns you want or setting to an empty string to exclude nothing.

If using tar as the backup method, then anything supported by its --exclude option can be provided which will be any glob pattern.

Kagenui-yozuru commented 9 months ago

ok,Thank you for your response.