search

itzg / docker-mc-proxy

A BungeeCord server to use in conjunction with itzg/minecraft-server
Apache License 2.0
205 stars 64 forks source link

RCON velocity plugin not download #197

Open astrons opened 3 months ago

astrons commented 3 months ago

When TYPE=VELOCITY and ENABLE_RCON = true, Tribufu-VelocityRcon-1.2.0.jar is not downloaded. The site includes human verification. If you download the plugin with a browser and copy it to the plugin folder, when the container starts, an attempt is still made to download the file and the container stops with an error. If the container variable RCON_VELOCITY_JAR_URL has its own address, then when the script starts, it is overwritten.

itzg commented 3 months ago

The container downloads it fine for me with

https://github.com/itzg/docker-bungeecord/blob/master/docs/velocity/docker-compose.yml#L11-L16

Can you provide container startup logs?

RCON_VELOCITY_JAR_URL is not documented as settable. It is a script local variable that happens to be upper-snake case so admittedly might seem confusing like it is an environment variable.

md5nake commented 2 months ago

Tribufu, the host responsible for hosting the RCON plugin for Velocity, has been experiencing a total outage tonight. Considering the security risks introduced by a third-party Maven repo, as well as the non-guaranteed uptime, would it be possible to add something like CREATE_CONSOLE_IN_PIPE from docker-minecraft-server so that the proxy can be controlled from within the container without relying on Tribufu's plugin?

guilhermewerner commented 2 months ago

Tribufu, the host responsible for hosting the RCON plugin for Velocity, has been experiencing a total outage tonight. Considering the security risks introduced by a third-party Maven repo, as well as the non-guaranteed uptime, would it be possible to add something like CREATE_CONSOLE_IN_PIPE from docker-minecraft-server so that the proxy can be controlled from within the container without relying on Tribufu's plugin?

Hello, I am the person responsible for Tribufu, I apologize for the incidents that took down the repository recently. I migrated the repository to a dedicated host today and will ensure its availability.

Regarding the security issues, the .jar was compiled directly from the repository tribufu-forks/VelocityRcon and can be checked if you have any questions.

I confess that the first time I didn't know that they were using the repository in this project, which I also use to host my servers, but I was happy when I found out.

I promise to keep the repository available online and I guarantee that no file will have malicious code. If you have any questions, you can contact me via discord (same username) or email (in my profile).

itzg commented 2 months ago

Thanks for the update @guilhermewerner -- your plugin has been a helpful piece in this solution.

Is the URL still correct here

https://github.com/itzg/docker-mc-proxy/blob/119bb46bf955f5122ed33212079ebb5defd2e4ef/scripts/run-bungeecord.sh#L28

guilhermewerner commented 2 months ago

Is the URL still correct here

Yes, that's right.

itzg commented 2 months ago

@astrons can you confirm download is working for you now? Please close the issue if so.