search

itzg / docker-minecraft-server

Docker image that provides a Minecraft Server that will automatically download selected version at startup
https://docker-minecraft-server.readthedocs.io/
Apache License 2.0
9.13k stars 1.51k forks source link

ERROR failed to auto-install CurseForge modpack #2007

Closed Mirexshell closed 1 year ago

Mirexshell commented 1 year ago

Describe the problem

tried to install create-dimensions with auto curseforge

Container definition

docker run -it -e EULA=TRUE -p 25565:25565 -v /home/zatto/docker/volume:/data -e TYPE=AUTO_CURSEFORGE -e CF_SLUG=create-dimensions -e CF_FILE_ID=4361733 --name modded_mc itzg/minecraft-server

Container logs

[init] Running as uid=1000 gid=1000 with /data as 'drwxrwxr-x 2 1000 1000 4096 Mar 15 14:02 /data' [init] Resolved version given LATEST into 1.19.4 and major version 1.19 [init] Resolving type given AUTO_CURSEFORGE [mc-image-helper] 18:04:52.021 INFO : Processing modpack 'Create_Dimensions_inDev-3.3.1_server_pack.zip' (create-dimensions) @ 467109:4361733 [mc-image-helper] 18:05:54.837 ERROR : 'install-curseforge' command failed. Version is 1.25.12 me.itzg.helpers.errors.GenericException: Modpack is missing manifest.json at me.itzg.helpers.curseforge.CurseForgeInstaller.extractModpackManifest(CurseForgeInstaller.java:736) at me.itzg.helpers.curseforge.CurseForgeInstaller.processModpackZip(CurseForgeInstaller.java:302) at me.itzg.helpers.curseforge.CurseForgeInstaller.downloadAndProcessModpackZip(CurseForgeInstaller.java:288) at me.itzg.helpers.curseforge.CurseForgeInstaller.processModPack(CurseForgeInstaller.java:198) at me.itzg.helpers.curseforge.CurseForgeInstaller.install(CurseForgeInstaller.java:135) at me.itzg.helpers.curseforge.InstallCurseForgeCommand.call(InstallCurseForgeCommand.java:143) at me.itzg.helpers.curseforge.InstallCurseForgeCommand.call(InstallCurseForgeCommand.java:21) at picocli.CommandLine.executeUserObject(CommandLine.java:2041) at picocli.CommandLine.access$1500(CommandLine.java:148) at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461) at picocli.CommandLine$RunLast.handle(CommandLine.java:2453) at picocli.CommandLine$RunLast.handle(CommandLine.java:2415) at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273) at picocli.CommandLine$RunLast.execute(CommandLine.java:2417) at picocli.CommandLine.execute(CommandLine.java:2170) at me.itzg.helpers.McImageHelper.main(McImageHelper.java:132) [init] ERROR failed to auto-install CurseForge modpack

itzg commented 1 year ago

I know it sounds counterintuitive, but CF_FILE_ID needs to reference the non-server file.

For context, server packs can be passed to the old TYPE=CURSEFORGE option, but there is very little consistency in server pack structure and they are very difficult to automate.

Mirexshell commented 1 year ago

so new problem

command: docker run -it -e EULA=TRUE -p 25565:25565 -v /home/zatto/docker/volume:/data -e TYPE=AUTO_CURSEFORGE -e CF_PAGE_URL=https://www.curseforge.com/minecraft/modpacks/create-dimensions/files/4361724 --name modded_mc itzg/minecraft-server

logs: [init] Running as uid=1000 gid=1000 with /data as 'drwxrwxr-x 5 1000 1000 4096 Mar 15 18:46 /data' [init] Resolved version given LATEST into 1.19.4 and major version 1.19 [init] Resolving type given AUTO_CURSEFORGE [mc-image-helper] 18:52:09.459 INFO : Processing modpack 'Create Dimensions-3.3.1.zip' (create-dimensions) @ 467109:4361724 [mc-image-helper] 18:55:14.411 INFO : Mod file mods/Galosphere-1.19.2-1.2.1-Forge.jar already exists [mc-image-helper] 18:55:14.417 INFO : Mod file mods/elenaidodge2-1.0.2.jar already exists [mc-image-helper] 18:55:14.486 INFO : Mod file mods/personality-1.19-3.0.1.jar already exists [mc-image-helper] 18:55:14.530 INFO : Mod file mods/swingthroughgrass-1.19.2-1.10.0.jar already exists [mc-image-helper] 18:55:14.530 INFO : Mod file mods/AI-Improvements-1.19.2-0.5.2.jar already exists [mc-image-helper] 18:55:14.539 INFO : Mod file mods/CreativeCore_FORGE_v2.9.3_mc1.19.2.jar already exists [mc-image-helper] 18:55:14.554 INFO : Mod file mods/Bookshelf-Forge-1.19.2-16.2.17.jar already exists [mc-image-helper] 18:55:14.589 INFO : Mod file mods/starterkit-1.19.2-5.0.jar already exists [mc-image-helper] 18:55:14.592 INFO : Mod file mods/TerraBlender-forge-1.19.2-2.0.1.136.jar already exists [mc-image-helper] 18:55:14.602 INFO : Mod file mods/catalogue-1.7.0-1.19.2.jar already exists [mc-image-helper] 18:55:14.606 INFO : Mod file mods/Clumps-forge-1.19.2-9.0.0+14.jar already exists [mc-image-helper] 18:55:14.614 INFO : Mod file mods/moonlight-1.19.2-2.1.31-forge.jar already exists [mc-image-helper] 18:55:14.650 INFO : Mod file mods/starlight-1.1.1+forge.cf5b10b.jar already exists [mc-image-helper] 18:55:14.651 INFO : Mod file mods/citadel-2.1.1-1.19.jar already exists [mc-image-helper] 18:55:14.657 INFO : Mod file mods/weaponmaster-multi-forge-1.19.x-3.0.3.jar already exists [mc-image-helper] 18:55:14.659 INFO : Mod file mods/cloth-config-8.2.88-forge.jar already exists [mc-image-helper] 18:55:14.660 INFO : Mod file mods/FarmersDelight-1.19-1.2.0.jar already exists [mc-image-helper] 18:55:14.662 INFO : Mod file mods/YungsBetterMineshafts-1.19.2-Forge-3.2.0.jar already exists [mc-image-helper] 18:55:14.662 INFO : Mod file mods/YungsApi-1.19.2-Forge-3.8.2.jar already exists [mc-image-helper] 18:55:14.663 INFO : Mod file mods/YungsBetterWitchHuts-1.19.2-Forge-2.1.0.jar already exists [mc-image-helper] 18:55:14.668 INFO : Mod file mods/CNB-1.19-1.5.0.jar already exists [mc-image-helper] 18:55:14.668 INFO : Mod file mods/Paraglider-1.19.2-1.7.0.3.jar already exists [mc-image-helper] 18:55:14.669 INFO : Mod file mods/BHMenu-Forge-1.19.2-1.3.jar already exists [mc-image-helper] 18:55:14.669 INFO : Mod file mods/Chunk Pregenerator-1.19-4.1.1.jar already exists [mc-image-helper] 18:55:14.670 INFO : Mod file mods/crittersandcompanions-1.19.2-1.1.2.jar already exists [mc-image-helper] 18:55:14.670 INFO : Mod file mods/BetterAdvancements-1.19.2-0.3.0.148.jar already exists [mc-image-helper] 18:55:14.678 INFO : Mod file mods/cloudstorage-1.3.4-1.19.2.jar already exists [mc-image-helper] 18:55:14.682 INFO : Mod file mods/nerb-1.19.2-0.2.jar already exists [mc-image-helper] 18:55:14.683 INFO : Mod file mods/infinitybuttons-1.19.2-3.1.0.jar already exists [mc-image-helper] 18:55:14.692 INFO : Mod file mods/NaturesCompass-1.19.2-1.10.0-forge.jar already exists [mc-image-helper] 18:55:14.693 INFO : Mod file mods/Patchouli-1.19.2-77.jar already exists [mc-image-helper] 18:55:14.709 INFO : Mod file mods/spiderstpo-1.19.2-2.0.4.jar already exists [mc-image-helper] 18:55:14.712 INFO : Mod file mods/supermartijn642configlib-1.1.6b-forge-mc1.19.jar already exists [mc-image-helper] 18:55:14.717 INFO : Mod file mods/ecologics-forge-1.19.2-2.1.11.jar already exists [mc-image-helper] 18:55:14.719 INFO : Mod file mods/Controlling-forge-1.19.2-10.0+7.jar already exists [mc-image-helper] 18:55:14.720 INFO : Mod file mods/drippyloadingscreen_forge_1.6.6_MC_1.19-1.19.2.jar already exists [mc-image-helper] 18:55:14.721 INFO : Mod file mods/backpacked-2.1.10-1.19.jar already exists [mc-image-helper] 18:55:14.725 INFO : Mod file mods/durabilitytooltip-1.1.4-forge-mc1.19.jar already exists [mc-image-helper] 18:55:14.726 INFO : Mod file mods/logprot-1.19.2-1.9.jar already exists [mc-image-helper] 18:55:14.727 INFO : Mod file mods/TravelersTitles-1.19.2-Forge-3.1.2.jar already exists [mc-image-helper] 18:55:14.728 INFO : Mod file mods/miningmaster-1.19.2-4.0.0.jar already exists [mc-image-helper] 18:55:14.735 INFO : Mod file mods/geckolib-forge-1.19-3.1.39.jar already exists [mc-image-helper] 18:55:14.736 INFO : Mod file mods/create-stuff-additions1.19.2_v2.0.2a.jar already exists [mc-image-helper] 18:55:14.738 INFO : Mod file mods/saturn-mc1.19.2-0.0.1.jar already exists [mc-image-helper] 18:55:14.741 INFO : Mod file mods/JER-Integration-4.3.1.jar already exists [mc-image-helper] 18:55:14.745 INFO : Mod file mods/PuzzlesLib-v4.3.12-1.19.2-Forge.jar already exists [mc-image-helper] 18:55:14.745 INFO : Mod file mods/cc-tweaked-1.19.2-1.101.1.jar already exists [mc-image-helper] 18:55:14.751 INFO : Mod file mods/botarium-forge-1.19.2-1.8.2.jar already exists [mc-image-helper] 18:55:14.766 INFO : Mod file mods/configured-2.0.1-1.19.2.jar already exists [mc-image-helper] 18:55:14.768 INFO : Mod file mods/rhino-forge-1902.2.2-build.264.jar already exists [mc-image-helper] 18:55:14.768 INFO : Mod file mods/structure_gel-1.19.2-2.7.1.jar already exists [mc-image-helper] 18:55:14.769 INFO : Mod file mods/xercamusic-1.19.2-1.0.2.jar already exists [mc-image-helper] 18:55:14.774 INFO : Mod file mods/crashutilities-6.2.jar already exists [mc-image-helper] 18:55:14.783 INFO : Mod file mods/gardens-of-the-dead-1.19.2-1.1.0.jar already exists [mc-image-helper] 18:55:14.784 INFO : Mod file mods/voicechat-forge-1.19.2-2.3.27.jar already exists [mc-image-helper] 18:55:14.788 INFO : Mod file mods/MouseTweaks-forge-mc1.19-2.23.jar already exists [mc-image-helper] 18:55:14.789 INFO : Mod file mods/pluto-mc1.19.2-0.0.7.jar already exists [mc-image-helper] 18:55:14.794 INFO : Mod file mods/v_slab_compat-1.19.2-1.4.jar already exists [mc-image-helper] 18:55:14.796 INFO : Mod file mods/YungsBetterStrongholds-1.19.2-Forge-3.2.0.jar already exists [mc-image-helper] 18:55:14.794 INFO : Mod file mods/netherportalfix-forge-1.19-10.0.0.jar already exists [mc-image-helper] 18:55:14.797 INFO : Mod file mods/Paxi-1.19.2-Forge-3.0.1.jar already exists [mc-image-helper] 18:55:14.797 INFO : Mod file mods/cd_addon-0.0.4-1.19.jar already exists [mc-image-helper] 18:55:14.798 INFO : Mod file mods/smallships-1.19.2-2.0.0-Alpha-0.4.jar already exists [mc-image-helper] 18:55:14.803 INFO : Mod file mods/SoL-Carrot-1.19.2-1.14.0.jar already exists [mc-image-helper] 18:55:14.805 INFO : Mod file mods/Steam_Rails-1.19.2-1.0.6.jar already exists [mc-image-helper] 18:55:14.806 INFO : Mod file mods/blueprint-1.19.2-6.1.0.jar already exists [mc-image-helper] 18:55:14.806 INFO : Mod file mods/JustEnoughResources-1.19.2-1.2.1.193.jar already exists [mc-image-helper] 18:55:14.814 INFO : Mod file mods/balm-4.5.3.jar already exists [mc-image-helper] 18:55:14.831 INFO : Mod file mods/valhelsia_structures-forge-1.19.2-1.0.1.jar already exists [mc-image-helper] 18:55:14.836 INFO : Mod file mods/toms_storage-1.19-1.3.10.jar already exists [mc-image-helper] 18:55:14.836 INFO : Mod file mods/InsaneLib-1.7.2-mc1.19.2.jar already exists [mc-image-helper] 18:55:14.837 INFO : Mod file mods/radon-0.8.2.jar already exists [mc-image-helper] 18:55:14.845 INFO : Mod file mods/fancymenu_forge_2.13.3_MC_1.19-1.19.2.jar already exists [mc-image-helper] 18:55:14.846 INFO : Mod file mods/lazydfu-1.19-1.0.2.jar already exists [mc-image-helper] 18:55:14.866 INFO : Mod file mods/kotlinforforge-3.9.1-all.jar already exists [mc-image-helper] 18:55:14.867 INFO : Mod file mods/Delightful-1.19-3.2.1.jar already exists [mc-image-helper] 18:55:14.872 INFO : Mod file mods/ShieldExpansion-1.19.2-1.1.5.jar already exists [mc-image-helper] 18:55:14.880 INFO : Mod file mods/XaerosWorldMap_1.28.8_Forge_1.19.1.jar already exists [mc-image-helper] 18:55:14.901 INFO : Mod file mods/create_misc_and_things_1.19.2_1.1B.jar already exists [mc-image-helper] 18:55:14.904 INFO : Mod file mods/firstjoinmessage-1.19.2-3.0.jar already exists [mc-image-helper] 18:55:14.934 INFO : Mod file mods/notenoughcrashes-4.2.1+1.19.2-forge.jar already exists [mc-image-helper] 18:55:14.961 INFO : Mod file mods/Structory-1.19-v1.3.jar already exists [mc-image-helper] 18:55:15.174 INFO : Mod file mods/spark-1.10.17-forge.jar already exists [mc-image-helper] 18:55:15.703 INFO : Mod file mods/MyServerIsCompatible-1.19-1.0.jar already exists [mc-image-helper] 18:55:15.726 INFO : Mod file mods/smoothboot(reloaded)-mc1.19.2-0.0.2.jar already exists [mc-image-helper] 18:55:15.756 INFO : Downloaded mod file mods/Fastload-Reforged-2.6.9+1.19.2.jar [mc-image-helper] 18:55:15.890 INFO : Downloaded mod file mods/Entity_Collision_FPS_Fix-forge-1.19-2.0.0.0.jar [mc-image-helper] 18:55:15.951 INFO : Mod file mods/feathers-1.0.3.jar already exists [mc-image-helper] 18:55:15.955 INFO : Mod file mods/BetterModsButton-v4.2.1-1.19.2-Forge.jar already exists [mc-image-helper] 18:55:16.053 INFO : Downloaded mod file mods/QuarkOddities-1.18.jar [mc-image-helper] 18:55:16.098 INFO : Downloaded mod file mods/alexsdelight-1.4.1.jar [mc-image-helper] 18:55:16.117 INFO : Downloaded mod file mods/shutupexperimentalsettings-1.0.5.jar [mc-image-helper] 18:55:16.203 INFO : Downloaded mod file mods/Backstab-1.19.2-1.2.jar [mc-image-helper] 18:55:16.247 INFO : Downloaded mod file mods/desiredservers-forge-1.19.2-1.1.0.jar [mc-image-helper] 18:55:16.268 INFO : Downloaded mod file mods/AutoRestart-1.19.2-2.0.1.jar [mc-image-helper] 18:55:16.306 INFO : Downloaded mod file mods/AttributeFix-Forge-1.19.2-17.1.3.jar [mc-image-helper] 18:55:16.359 INFO : Downloaded mod file mods/BetterThirdPerson-Forge-1.19-1.9.0.jar [mc-image-helper] 18:55:16.697 INFO : Downloaded mod file mods/secondchanceforge-1.19-1.5.1.jar [mc-image-helper] 18:55:16.822 INFO : Downloaded mod file mods/ClaimChunk-1.19-1.0.15.jar [mc-image-helper] 18:55:16.832 INFO : Downloaded mod file mods/breezy-1.19.2-1.0.4.jar [mc-image-helper] 18:55:16.967 INFO : Downloaded mod file mods/AutoRegLib-1.8.2-55.jar [mc-image-helper] 18:55:16.986 INFO : Downloaded mod file mods/JadeAddons-1.19.2-forge-3.3.0.jar [mc-image-helper] 18:55:17.004 INFO : Downloaded mod file mods/Atlas-Lib-1.19.2-1.1.6.jar [mc-image-helper] 18:55:17.024 INFO : Downloaded mod file mods/curios-forge-1.19.2-5.1.1.0.jar [mc-image-helper] 18:55:17.028 INFO : Downloaded mod file mods/SimpleBackups-1.19.1-2.1.8.jar [mc-image-helper] 18:55:17.109 INFO : Downloaded mod file mods/reusable_rockets-1.19.2-1.0.0.jar [mc-image-helper] 18:55:17.230 INFO : Downloaded mod file mods/deuf-1.19.2-1.3.jar [mc-image-helper] 18:55:17.268 INFO : Downloaded mod file mods/sliceanddice-2.0.0.jar [mc-image-helper] 18:55:17.341 INFO : Downloaded mod file mods/BadMobs-1.19.2-16.1.3.jar [mc-image-helper] 18:55:17.924 INFO : Downloaded mod file mods/ferritecore-5.0.3-forge.jar [mc-image-helper] 18:55:17.925 INFO : Downloaded mod file mods/Raided-1.19.2-0.1.2.jar [mc-image-helper] 18:55:17.926 INFO : Downloaded mod file mods/mobcompack-0.0.3.8-1.19.2.jar [mc-image-helper] 18:55:17.926 INFO : Downloaded mod file mods/mosaic_carpentry-1.2-1.19.2.jar [mc-image-helper] 18:55:17.949 INFO : Downloaded mod file mods/collective-1.19.2-6.43.jar [mc-image-helper] 18:55:18.091 INFO : Downloaded mod file mods/NethersDelight-1.19-3.0.jar [mc-image-helper] 18:55:18.145 INFO : Downloaded mod file mods/appleskin-forge-mc1.19-2.4.2.jar [mc-image-helper] 18:55:18.159 INFO : Downloaded mod file mods/archers_paradox-1.19.2-4.0.0.11.jar [mc-image-helper] 18:55:18.183 INFO : Downloaded mod file mods/Structory_Towers_1.19_v1.0.1.jar [mc-image-helper] 18:55:18.370 INFO : Downloaded mod file mods/Quicksand-1.3.0+forge-mc1.19.2.jar [mc-image-helper] 18:55:18.504 INFO : Downloaded mod file mods/alloyed-1.19.2-v1.5.jar [mc-image-helper] 18:55:18.573 INFO : Downloaded mod file mods/Log-Begone-Forge-1.19-1.0.4.jar [mc-image-helper] 18:55:18.920 INFO : Downloaded mod file mods/dummmmmmy-1.19.2-1.6.1.jar [mc-image-helper] 18:55:18.920 INFO : Downloaded mod file mods/rottencreatures-forge-1.19.2-1.0.1.jar [mc-image-helper] 18:55:19.054 INFO : Downloaded mod file mods/eerreforged-1.19-1.0.2.jar [mc-image-helper] 18:55:19.086 INFO : Downloaded mod file mods/Jade-1.19.1-forge-8.7.0.jar [mc-image-helper] 18:55:19.131 INFO : Downloaded mod file mods/SereneSeasons-1.19.2-8.1.0.24.jar [mc-image-helper] 18:55:19.341 INFO : Downloaded mod file mods/YungsBetterDungeons-1.19.2-Forge-3.2.2.jar [mc-image-helper] 18:55:19.533 INFO : Downloaded mod file mods/guardvillagers-1.19.2-1.5.2.jar [mc-image-helper] 18:55:19.537 INFO : Downloaded mod file mods/smoothchunk-1.19.1-2.0.jar [mc-image-helper] 18:55:19.636 INFO : Downloaded mod file mods/cofh_core-1.19.2-10.0.2.33.jar [mc-image-helper] 18:55:19.695 INFO : Downloaded mod file mods/hourglass-1.19.1-1.2.1.1.jar [mc-image-helper] 18:55:19.930 INFO : Downloaded mod file mods/create_enchantment_industry-1.19.2-for-create-0.5.0.g-1.1.9.jar [mc-image-helper] 18:55:19.948 INFO : Downloaded mod file mods/spyglass_improvements-1.4+mc1.19+forge.jar [mc-image-helper] 18:55:19.980 INFO : Downloaded mod file mods/domesticationinnovation-1.6.1-1.19.2.jar [mc-image-helper] 18:55:19.987 INFO : Downloaded mod file mods/jei-1.19.2-forge-11.5.2.1007.jar [mc-image-helper] 18:55:20.101 INFO : Downloaded mod file mods/waystones-forge-1.19-11.1.0.jar [mc-image-helper] 18:55:20.533 INFO : Downloaded mod file mods/Xaeros_Minimap_FP22.16.3_Forge_1.19.1.jar [mc-image-helper] 18:55:20.888 INFO : Downloaded mod file mods/automobility-0.4.1+1.19.2-forge.jar [mc-image-helper] 18:55:21.060 INFO : Downloaded mod file mods/creeperoverhaul-2.0.6-forge.jar [mc-image-helper] 18:55:21.141 INFO : Downloaded mod file mods/konkrete_forge_1.6.0_MC_1.19-1.19.2.jar [mc-image-helper] 18:55:22.059 INFO : Downloaded mod file mods/valhelsia_core-forge-1.19.2-0.5.0.jar [mc-image-helper] 18:55:22.222 INFO : Downloaded mod file mods/DarkerDepths-1.19-1.0.6-patch3.jar [mc-image-helper] 18:55:22.864 INFO : Downloaded mod file mods/obscure_api-11.jar [mc-image-helper] 18:55:22.864 INFO : Downloaded mod file mods/create_crystal_clear-0.1.2e-1.19.2.jar [mc-image-helper] 18:55:23.085 INFO : Downloaded mod file mods/createaddition-1.19.2-20221230a.jar [mc-image-helper] 18:55:23.843 INFO : Downloaded mod file mods/Towns-and-Towers-v.1.10-FORGE-1.19.2.jar [mc-image-helper] 18:55:24.608 INFO : Downloaded mod file mods/CraftTweaker-forge-1.19.2-10.0.29.jar [mc-image-helper] 18:55:25.100 INFO : Downloaded mod file mods/everycomp-1.19.2-2.2.3.jar [mc-image-helper] 18:55:25.305 INFO : Downloaded mod file mods/mmode-forge-1.19-1.1.1d.jar [mc-image-helper] 18:55:25.941 INFO : Downloaded mod file mods/artifacts-1.19.2-5.0.1.jar [mc-image-helper] 18:55:26.181 INFO : Downloaded mod file mods/create-confectionery1.19.2_v1.0.8.jar [mc-image-helper] 18:55:26.547 INFO : Downloaded mod file mods/ToughAsNails-1.19-8.0.0.78.jar [mc-image-helper] 18:55:27.026 INFO : Downloaded mod file mods/resourcefullib-forge-1.19.2-1.1.19.jar [mc-image-helper] 18:55:31.344 INFO : Downloaded mod file mods/another_furniture-forge-2.1.2-1.19.2.jar [mc-image-helper] 18:55:31.605 INFO : Downloaded mod file mods/YungsBetterOceanMonuments-1.19.2-Forge-2.1.0.jar [mc-image-helper] 18:55:32.294 INFO : Downloaded mod file mods/createdeco-1.2.12-1.19.2.jar [mc-image-helper] 18:55:32.793 INFO : Downloaded mod file mods/allurement-1.19-3.0.0.jar [mc-image-helper] 18:55:33.164 INFO : Downloaded mod file mods/valhelsia_furniture-forge-1.19.2-1.0.2.jar [mc-image-helper] 18:55:34.424 INFO : Downloaded mod file mods/savage_and_ravage-1.19-5.0.2.jar [mc-image-helper] 18:55:38.813 INFO : Downloaded mod file mods/YungsBetterDesertTemples-1.19.2-Forge-2.2.1.jar [mc-image-helper] 18:55:40.076 INFO : Downloaded mod file mods/dungeons_plus-1.19.2-1.3.0.jar [mc-image-helper] 18:55:43.933 INFO : Downloaded mod file mods/FarmersRespite-1.19-2.0.jar [mc-image-helper] 18:56:25.301 INFO : Downloaded mod file mods/Terralith_v2.3.6.jar [mc-image-helper] 18:57:49.490 INFO : Downloaded mod file mods/windswept-1.19.2-2.0.2.jar [mc-image-helper] 18:59:13.351 INFO : Downloaded mod file mods/create-1.19.2-0.5.0.g.jar [mc-image-helper] 19:01:55.079 ERROR : 'install-curseforge' command failed. Version is 1.25.12 io.netty.handler.timeout.ReadTimeoutException: null [init] ERROR failed to auto-install CurseForge modpack

itzg commented 1 year ago

Did you try running it again to see if it would get past the network issue? If not, add -e DEBUG=true and start the container again.

mterhar commented 1 year ago

I'm getting the same problem as this using the included one-block-modded example.

[mc-image-helper] 15:49:54.988 DEBUG : JSON FETCH: uri=https://api.curseforge.com/v1/mods/369096/files/4136487 headers=DefaultHttpHeaders[user-agent: mc-image-helper/1.25.22 (cmd=install-curseforge), x-fetch-session: 84d2ce21-f0b3-4827-a0e1-ef63c526e892, x-api-key: [REDACTED], accept: application/json, host: api.curseforge.com]
minecraft_oneblock-minecraft_oneblock-1  | [mc-image-helper] 15:49:55.015 INFO  : Processing modpack 'Modded Oneblock 1.6.0-1.19' (one-block-modded) @ 369096:4136487
minecraft_oneblock-minecraft_oneblock-1  | [mc-image-helper] 15:49:55.017 ERROR : 'install-curseforge' command failed. Version is 1.25.22
minecraft_oneblock-minecraft_oneblock-1  | java.lang.NullPointerException: null
minecraft_oneblock-minecraft_oneblock-1  |  at me.itzg.helpers.curseforge.CurseForgeInstaller.normalizeDownloadUrl(CurseForgeInstaller.java:817)
minecraft_oneblock-minecraft_oneblock-1  |  at me.itzg.helpers.curseforge.CurseForgeInstaller.processModPack(CurseForgeInstaller.java:208)
minecraft_oneblock-minecraft_oneblock-1  |  at me.itzg.helpers.curseforge.CurseForgeInstaller.install(CurseForgeInstaller.java:138)
minecraft_oneblock-minecraft_oneblock-1  |  at me.itzg.helpers.curseforge.InstallCurseForgeCommand.call(InstallCurseForgeCommand.java:161)
minecraft_oneblock-minecraft_oneblock-1  |  at me.itzg.helpers.curseforge.InstallCurseForgeCommand.call(InstallCurseForgeCommand.java:23)
minecraft_oneblock-minecraft_oneblock-1  |  at picocli.CommandLine.executeUserObject(CommandLine.java:2041)
minecraft_oneblock-minecraft_oneblock-1  |  at picocli.CommandLine.access$1500(CommandLine.java:148)
minecraft_oneblock-minecraft_oneblock-1  |  at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
minecraft_oneblock-minecraft_oneblock-1  |  at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
minecraft_oneblock-minecraft_oneblock-1  |  at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
minecraft_oneblock-minecraft_oneblock-1  |  at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
minecraft_oneblock-minecraft_oneblock-1  |  at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
minecraft_oneblock-minecraft_oneblock-1  |  at picocli.CommandLine.execute(CommandLine.java:2170)
minecraft_oneblock-minecraft_oneblock-1  |  at me.itzg.helpers.McImageHelper.main(McImageHelper.java:132)
minecraft_oneblock-minecraft_oneblock-1  | + log 'ERROR failed to auto-install CurseForge modpack'
minecraft_oneblock-minecraft_oneblock-1  | + local oldState
minecraft_oneblock-minecraft_oneblock-1  | ++ shopt -po xtrace
minecraft_oneblock-minecraft_oneblock-1  | + oldState='set -o xtrace'
minecraft_oneblock-minecraft_oneblock-1  | + shopt -u -o xtrace
minecraft_oneblock-minecraft_oneblock-1  | [init] 2023-04-01 15:49:55-04:00 ERROR failed to auto-install CurseForge modpack
minecraft_oneblock-minecraft_oneblock-1  | + exit 1
minecraft_oneblock-minecraft_oneblock-1 exited with code 1

Not sure which pointer is null. The exception isn't particularly helpful.

Here's the docker-compose.yml file contents if that helps. The env_file only has the CF_API_KEY since the $s weren't escaping properly in the yaml. 

version: "3.8"

services:
  minecraft_oneblock:
    image: itzg/minecraft-server:java8
    ports:
      - "25567:25565"
    env_file:
      - /stwo/docker/minecraft_oneblock/.env
    environment:
      EULA: "true"
      TYPE: AUTO_CURSEFORGE
      CF_PAGE_URL: "https://www.curseforge.com/minecraft/modpacks/one-block-modded/files/4136487"
      DEBUG: "true"
      MEMORY: 4G
      TZ: 'America/New_York'
      GID: 100
      UID: 1002
      OPS: "mterhar"
      MAX_MEMORY: "6G"
      VIEW_DISTANCE: 7
    volumes:
      - /stwo/docker/minecraft_oneblock/data:/data

If I switch the image to itzg/minecraft-server without java8 it shows this error instead.

minecraft_oneblock-minecraft_oneblock-1  | [mc-image-helper] 16:53:17.871 ERROR : 'install-curseforge' command failed. Version is 1.25.22
minecraft_oneblock-minecraft_oneblock-1  | java.lang.NullPointerException: Cannot invoke "String.lastIndexOf(int)" because "downloadUrl" is null
itzg commented 1 year ago

Thanks, that'll give me correct line numbers to inspect. And your log made me realize that I need to be redacted the api key from the headers, unless that wasn't you doing that.

itzg commented 1 year ago

I'll investigate the API response but it's basically finding the modpack metadata is reporting a null download URL. I have an open issue with CurseForge about that problem with random mod files...but zero response from them 😑

Side note: it's nice how the newer Java version reports a more precise NPE cause.

itzg commented 1 year ago

Their API is again giving a response that does not include a download URL:

GET https://api.curseforge.com/v1/mods/369096/files/4136487
x-api-key: {{cfApiKey}}

returns the following

{
  "data": {
    "id": 4136487,
    "gameId": 432,
    "modId": 369096,
    "isAvailable": true,
    "displayName": "Modded Oneblock 1.6.0-1.19",
    "fileName": "Modded OneBock.zip",
    "releaseType": 1,
    "fileStatus": 4,
    "hashes": [
      {
        "value": "1b3561dec984b288b6163d867cb2653052c42812",
        "algo": 1
      },
      {
        "value": "288d52aa96e96f27b081344b18136516",
        "algo": 2
      }
    ],
    "fileDate": "2022-12-05T23:46:12.517Z",
    "fileLength": 7648486,
    "downloadCount": 0,
    "downloadUrl": null,
    "gameVersions": [
      "1.19.3",
      "1.19.2",
      "Forge",
      "1.19.1",
      "1.19"
    ],
    "sortableGameVersions": [
      {
        "gameVersionName": "1.19.3",
        "gameVersionPadded": "0000000001.0000000019.0000000003",
        "gameVersion": "1.19.3",
        "gameVersionReleaseDate": "2022-10-19T00:00:00Z",
        "gameVersionTypeId": 73407
      },
      {
        "gameVersionName": "1.19.2",
        "gameVersionPadded": "0000000001.0000000019.0000000002",
        "gameVersion": "1.19.2",
        "gameVersionReleaseDate": "2022-08-05T14:12:22.413Z",
        "gameVersionTypeId": 73407
      },
      {
        "gameVersionName": "Forge",
        "gameVersionPadded": "0",
        "gameVersion": "",
        "gameVersionReleaseDate": "2019-08-01T00:00:00Z",
        "gameVersionTypeId": 68441
      },
      {
        "gameVersionName": "1.19.1",
        "gameVersionPadded": "0000000001.0000000019.0000000001",
        "gameVersion": "1.19.1",
        "gameVersionReleaseDate": "2022-06-28T00:00:00Z",
        "gameVersionTypeId": 73407
      },
      {
        "gameVersionName": "1.19",
        "gameVersionPadded": "0000000001.0000000019",
        "gameVersion": "1.19",
        "gameVersionReleaseDate": "2022-06-07T15:38:07.377Z",
        "gameVersionTypeId": 73407
      }
    ],
    "dependencies": [],
    "alternateFileId": 0,
    "isServerPack": false,
    "fileFingerprint": 3020746965,
    "modules": [
      {
        "name": "manifest.json",
        "fingerprint": 734524076
      }
    ]
  }
}

I'm not sure how to proceed since CurseForge hasn't replied to my ticket.

mterhar commented 1 year ago

What's the right way to download and reference that zip file? I don't need it to be dynamic but setting the type to FORGE or CURSEFORGE both seemed to fail.

I just saw the change from 4 days ago to include CF_MODPACK_ZIP in the volume. Thanks!

itzg commented 1 year ago

I had forgotten this issue also was cause by the same thing fixed in referenced PR.

Yes, @mterhar , that is correct. A paragraph has been added here for CF_MODPACK_ZIP

https://github.com/itzg/docker-minecraft-server#auto-curseforge-management

itzg commented 1 year ago

@Mirexshell with the latest support for modpacks that are prohibited from automated downloads, can you confirm if your OP is solved?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Please add a comment describing the reason to keep this issue open.