itzg
commented
1 year ago I'll change it to check the downloadUrl which is really what mattered. I made a bad assumption that isAvailable would be false when the downloadUrl was null.
Closed KundaPanda closed 1 year ago
itzg
commented
1 year ago I'll change it to check the downloadUrl which is really what mattered. I made a bad assumption that isAvailable would be false when the downloadUrl was null.
itzg
commented
1 year ago Some of the modpack files are still reporting a null downloadUrl, such as
[mc-image-helper] 07:44:02.788 WARN : The file It Takes A Pillage v1.0.4 [1.19.2] from It Takes a Pillage (Fabric) did not provide a download URL, so it will be skipped. Metadata retrieved from https://api.curseforge.com/v1/mods/694605/files/4098018There's an API endpoint, such as https://api.curseforge.com/v1/mods/694605/files/4098018/download-url, however, I just get a 403 forbidden even with a valid API key.
itzg
commented
1 year ago The image from this build will help,
https://github.com/itzg/docker-minecraft-server/actions/runs/4564700516
but some mod file metadata is still reporting null downloadUrl when the web page for it works.
itzg
commented
1 year ago I have emailed the Eternal support at Overwolf, so hopefully they will have a fix/answer.
LodSb-2
commented
1 year ago I'm having a similar problem, but I'm not sure if it's fully related or not. My server was working fine before, so if there's a way to force it to just not check for mods, and use the ones already in the mods folder I'll appreciate that too.
Compose File:
version: "3"
services:
mc:
container_name: "mc"
image: itzg/minecraft-server:java8-jdk
ports:
- 25565:25565
environment:
CF_API_KEY: "----"
CF_EXCLUDE_MODS: 606159,379768,401648,435044,511733,250398,297038,257814,232131,511770,502561,422719,815304,367706,513769,270441,240630,410295,532127,558905,60089,513857,581495,529754,574856,222789,271740
EXEC_DIRECTLY: "TRUE"
EULA: "TRUE"
TYPE: "AUTO_CURSEFORGE"
DIFFICULTY: "NORMAL"
ENABLE_WHITELIST: "TRUE"
ENFORCE_WHITELIST: "TRUE"
OPS: "----"
SPAWN_PROTECTION: "0"
MEMORY: "10G"
CF_PAGE_URL: "https://www.curseforge.com/minecraft/modpacks/roguelike-adventures-and-dungeons-2"
VIEW_DISTANCE: "10"
ALLOW_FLIGHT: "TRUE"
WHITELIST: ----
RCON_CMDS_STARTUP: |-
gamerule doFireTick false
VANILLATWEAKS_SHARECODE: XjWEwC
DEBUG: "TRUE"
tty: true
stdin_open: true
restart: unless-stopped
volumes:
- ./minecraft-data:/dataAnd logs:
The excluded mods are all client side as I was having an issue with some of them ending up in the server files, so I just removed all client side mods and that fixed the issue a while ago.
itzg
commented
1 year ago @AsiPanda @LodSb-2 , both of you need to re-pull the latest image and then can debug any remaining issues from there.
itzg
commented
1 year ago so if there's a way to force it to just not check for mods
Ah, that might actually be a bug that I can fix. The ones that don't provide a downloadUrl can/should still be treated as if they were downloaded...unless the metadata doesn't even provide a resulting filename.
LodSb-2
commented
1 year ago @AsiPanda @LodSb-2 , both of you need to re-pull the latest image and then can debug any remaining issues from there.
Re-pulling fixed the issue! I was under the misconception that using --build with docker compose automatically pulls latest, but I had to use docker compose pull first. Thank you for the help!
itzg
commented
1 year ago Current image build includes usage of /downloads (or other path of your choosing) to use for mods and modpacks that can't be automatically downloaded. More info in the paragraph that starts here.
Describe the problem
After the switch to the official CF API, mc-image-helper is unable to download any mods.
I have turned on the debug logging and checked that metadata for all mods included in a modpack gets fetched from the API but is deemed unavailable for download here.
I sent requests for multiple mod metadata using the API, and all of them had
"isAvailable": true,.Because of this, no mods are downloaded, and the server fails to start.
Container definition
Container logs
Logs