itzg / docker-minecraft-server

Docker image that provides a Minecraft Server that will automatically download selected version at startup
https://docker-minecraft-server.readthedocs.io/
Apache License 2.0
9.02k stars 1.5k forks source link

Support for neoforge #2362

Closed shayanz23 closed 10 months ago

shayanz23 commented 11 months ago

Hi, a few months ago a new forge fork was made called neoforged with almost all the forge team moving to it, and I think since it is practically a forge replacement, it should also be supported as server type or at least version of forge.

Edit: Some mods like https://www.curseforge.com/minecraft/mc-mods/railcraft-reborn are already starting to warn that in the future they will only support neoforge.

itzg commented 11 months ago

Why do half the time they call it "neoforged" with a "d" and "neoforge" without? Which is their main identifier or do I have to allow confused users to request it by either name?

https://neoforged.net/

shayanz23 commented 11 months ago

mb, I meant neoforged.

itzg commented 11 months ago

You're good. I mean on their own website they use both 😀

shayanz23 commented 11 months ago

Lol didn't even realise till now, no wonder I messed up.

heipiao233 commented 10 months ago

You're good. I mean on their own website they use both 😀

NeoForge is project, NeoForged is team

itzg commented 10 months ago

Thanks @heipiao233 ! Wanted to make sure the correct term was exposed.

itzg commented 10 months ago

To poke a bit of fun (and justify why I have been asking)

image

So with the "d" it's the collective team and project perhaps? Without the "d" is the specific modloader product.

itzg commented 10 months ago

@shayanz23 @heipiao233 where is the neoforge equivalent of https://files.minecraftforge.net/net/minecraftforge/forge/promotions_slim.json ? Their docs only mention their maven repo and their Discord server is not publicly listed.

I cannot proceed without this information.

The URL listed here is not valid

https://github.com/neoforged/NeoForge/blob/55133ebdb40c8e83d8d816b5bdf06c0683c48116/src/main/resources/META-INF/mods.toml#L11

Image

itzg commented 10 months ago

Blocked by https://github.com/neoforged/NeoForge/issues/52

itzg commented 10 months ago

With clarification in https://github.com/neoforged/NeoForge/issues/52#issuecomment-1742119053 I can now proceed.

itzg commented 10 months ago

Development notes

Selecting NeoForge from modpacks doesn't seem to be supported yet. For example,