itzg / docker-minecraft-server

Docker image that provides a Minecraft Server that will automatically download selected version at startup
https://docker-minecraft-server.readthedocs.io/
Apache License 2.0
9.56k stars 1.56k forks source link

Add PAPER_CONFIG_REPO as alias for defaults repo variable #3076

Closed Alpha018 closed 1 month ago

Alpha018 commented 1 month ago

Hello, I propose setting the paper config files with an env var. To create an optimized config, I made a new repo in this link. Follow the doc of this other link and this discord server. If you want to add more files to the repo with optimization files, please feel free to make a PR.

Alpha018 commented 1 month ago

@itzg I added two new optional environment variables if you want to set the new config files or if you have a repo to place the files yourself; let me know if you think it is a good idea or if you prefer to make any changes. I am open to new comments.

Alpha018 commented 1 month ago

@itzg I can make that change. Also, can I add my repository in the example docs?? In any case, give me until the end of the day to change the PR and give me to this final day.

itzg commented 1 month ago

No rush at all.

Yes, providing the links to your repo and supporting article make sense to include within the example directory/compose file.

Alpha018 commented 1 month ago

I tested this change with both variables and works. I tried to use the "patching existing files" option, but making some strong modifications is tough. I can't delete some variables and set some maps. 🤔 I don't know if this change convinced you to change the config files with another kind of properties.

itzg commented 1 month ago

Thanks for confirming the change.

That's understandable since the patching can already be a little tedious. In that case, the example you have included with the aliased variable of PAPER_CONFIG_REPO seems good as it is.

Alpha018 commented 1 month ago

@itzg I try to improve the information for better clarity. 😄