Neoforge version tag does not force the compose to pull that version

Dutchiiee commented 1 week ago

Describe the problem

As the title says when you specify the Neoforge version in the docker compose file it gets ignored and still pulls the latest release of Neoforge.

Container definition

mcb-vanilla: container_name: minecraft-modded image: itzg/minecraft-server ports:

"25565:25565" volumes:
- "/mnt/drive2/Fileshare/Docker/mcb-vanilla:/data"
- "/mnt/drive2/Fileshare/Docker/mcb-vanilla/plugins:/plugins"
- "/mnt/drive2/Fileshare/Docker/mcb-vanilla/common/banned-ips.json:/data/banned-ips.json"
- "/mnt/drive2/Fileshare/Docker/mcb-vanilla/common/banned-players.json:/data/banned-players.json"
- "/mnt/drive2/Fileshare/Docker/mcb-vanilla/common/banned-ips.json:/data/FeedTheBeast/banned-ips.json"
- "/mnt/drive2/Fileshare/Docker/mcb-vanilla/common/banned-players.json:/data/FeedTheBeast/banned-players.json" environment: EULA: "TRUE" ONLINE_MODE: "True" TYPE: "Neoforge" VERSION: "1.21.1" NEOFORGE_VERSION: "21.1.59" SERVER_NAME: "" OPS: "" FORCE_GAMEMODE: "true" MODE: "survival" MAX_MEMORY: "8G" SEED: "Mixer" MOTD: "A Custom Craftoria Server" ENABLE_RCON: "true" RCON_PASSWORD: "" RCON_PORT: 28016 restart: unless-stopped networks:
- mc

Container logs

Paste logs here

itzg commented 1 week ago

I am unable to recreate this issue. Please make sure you have re-pulled the latest image. If you are still experiencing problems, set the env var DEBUG to "true" and provide those logs. For comparison, here are the logs of my test:

2024-10-06T21:54:44.713862838Z + mc-image-helper install-neoforge --output-directory=/data --results-file=/data/.run-neoforge.env --minecraft-version=1.21.1 --neoforge-version=21.1.59 --force-reinstall=false
2024-10-06T21:54:45.383246964Z [mc-image-helper] 21:54:45.382 DEBUG : Requesting NeoForge version=21.1.59 for minecraft=1.21.1
2024-10-06T21:54:45.711115422Z [mc-image-helper] 21:54:45.710 DEBUG : JSON FETCH: uri=https://maven.neoforged.net/releases/net/neoforged/neoforge/maven-metadata.xml headers=[user-agent: itzg/mc-image-helper/1.39.12 (cmd=install-neoforge), x-fetch-session: 3717063b-0488-4447-9c33-f69ec3b37bc0, host: maven.neoforged.net, accept: */*]
2024-10-06T21:54:46.273894256Z [mc-image-helper] 21:54:46.273 DEBUG : Resolved installer version=VersionPair(minecraft=1.21.1, forge=21.1.59)
2024-10-06T21:54:46.278118297Z [mc-image-helper] 21:54:46.277 DEBUG : FILE FETCH: uri=https://maven.neoforged.net/releases/net/neoforged/neoforge/21.1.59/neoforge-21.1.59-installer.jar headers=[user-agent: itzg/mc-image-helper/1.39.12 (cmd=install-neoforge), x-fetch-session: 3717063b-0488-4447-9c33-f69ec3b37bc0, host: maven.neoforged.net, accept: */*]
2024-10-06T21:54:46.636724298Z [mc-image-helper] 21:54:46.636 DEBUG : Download of https://maven.neoforged.net/releases/net/neoforged/neoforge/21.1.59/neoforge-21.1.59-installer.jar took 360ms at 18844 KB/s
2024-10-06T21:54:46.637371714Z [mc-image-helper] 21:54:46.637 INFO  : Running NeoForge 21.1.59 installer for Minecraft 1.21.1. This might take a while...
2024-10-06T21:54:50.667654383Z

using

services:
  mc:
    image: itzg/minecraft-server
    environment:
      EULA: true
      TYPE: NEOFORGE
      VERSION: "1.21.1"
      NEOFORGE_VERSION: "21.1.59"
      DEBUG: true

Dutchiiee commented 1 week ago

Hi there! Thanks for the response!!

i pulled the latest image and it seems to be fixed now.

itzg / docker-minecraft-server