Property override not working with docker compose

[BlueDragon709]

Hi,

When i set the max players and MOTD of the server it won't set them.

version: "3.8"
services:
    mc:
        container_name: Roguelike_Modpack
        image: itzg/minecraft-server:java8-multiarch
        restart: unless-stopped
        environment:
          TZ: Europe/Amsterdam
          EULA: "TRUE"
          TYPE: "CURSEFORGE"
          OVERRIDE_SERVER_PROPERTIES: "TRUE"
          WHITELIST: "Player1,Player2"
          OPS: "Player1"
          MOTD: "New Beginnings V1.45"
          MAX_PLAYERS: "4"
          ALLOW_FLIGHT: "TRUE"
          MEMORY: "4G"
          CF_SERVER_MOD: "/modpacks/RAD-Serverpack-1.45.zip"
        ports:
            - "25565:25565"
        volumes:
            - /home/blue/roguelike_modpack:/data
            - /home/blue/modpacks:/modpacks

The other properties work as expected, but the MOTD and MAX_PLAYERS don't work. How do I fix this.

[BlueDragon709]

It seems that the server.properties file is cot coppied to the actual modpack install location. Currenctly it resides in the /data directory. But it is supposed to go to /data/FeedTheBeast/modpack_name directory

[itzg]

That's strange, it should have already been supported at

https://github.com/itzg/docker-minecraft-server/blob/75f5a430e48e85f24e8339aba8c00ecd70ba2366/start-finalSetupServerProperties#L185

I pushed an image update that wraps that path in quotes; however, RAD doesn't expand to a path with spaces in the name.

See if the latest image happens to fix it for you. If not, add DEBUG: "true" to the variables and provide that output.

[BlueDragon709]

Do i need to provide the debug info from complete recreation or from docker-compose up?

[BlueDragon709]

this is the Debug output. But the server properties in the actual modpack_name folder is not the same as the one in /data

[init] Running as uid=1000 gid=1000 with /data as 'drwxrwxr-x 3 1000 1000 4096 Apr 26 12:06 /data'
[init] Resolved version given LATEST into 1.16.5
[init] Resolving type given CURSEFORGE
+ : /data/FeedTheBeast
+ export FTB_BASE_DIR
+ legacyJavaFixerUrl=https://ftb.forgecdn.net/FTB2/maven/net/minecraftforge/lex/legacyjavafixer/1.0/legacyjavafixer-1.0.jar
+ export TYPE=CURSEFORGE
+ TYPE=CURSEFORGE
+ FTB_SERVER_MOD=/modpacks/RAD-Serverpack-1.45.zip
+ log 'Looking for Feed-The-Beast / CurseForge server modpack.'
+ echo '[init] Looking for Feed-The-Beast / CurseForge server modpack.'
+ requireVar FTB_SERVER_MOD
[init] Looking for Feed-The-Beast / CurseForge server modpack.
+ '[' '!' -v FTB_SERVER_MOD ']'
+ '[' -z /modpacks/RAD-Serverpack-1.45.zip ']'
+ isTrue true
+ local value=true

=
+ case ${value} in
+ result=0
+ return 0
+ entryScriptExpr='
  -name ServerStart.sh
  -o -name serverstart.sh
  -o -name ServerStartLinux.sh
  -o -name LaunchServer.sh
  -o -name server-start.sh
  -o -name startserver.sh
  -o -name StartServer.sh
  '
+ [[ -d /data/FeedTheBeast ]]
++ find /data/FeedTheBeast -name ServerStart.sh -o -name serverstart.sh -o -name ServerStartLinux.sh -o -name LaunchServer.sh -o -name server-start.sh -o -name startserver.sh -o -name StartServer.sh
++ wc -l
+ startScriptCount=1
+ [[ 1 > 1 ]]
+ [[ 1 = 0 ]]
++ find /data/FeedTheBeast -name ServerStart.sh -o -name serverstart.sh -o -name ServerStartLinux.sh -o -name LaunchServer.sh -o -name server-start.sh -o -name startserver.sh -o -name StartServer.sh
++ wc -l
+ [[ 1 = 0 ]]
++ find /data/FeedTheBeast -name ServerStart.sh -o -name serverstart.sh -o -name ServerStartLinux.sh -o -name LaunchServer.sh -o -name server-start.sh -o -name startserver.sh -o -name StartServer.sh
++ wc -l
+ scriptCount=1
+ [[ 1 = 0 ]]
+ [[ 1 > 1 ]]
++ find /data/FeedTheBeast -name ServerStart.sh -o -name serverstart.sh -o -name ServerStartLinux.sh -o -name LaunchServer.sh -o -name server-start.sh -o -name startserver.sh -o -name StartServer.sh
+ export FTB_SERVER_START=/data/FeedTheBeast/RAD-Serverpack-1.45/LaunchServer.sh
+ FTB_SERVER_START=/data/FeedTheBeast/RAD-Serverpack-1.45/LaunchServer.sh
++ dirname /data/FeedTheBeast/RAD-Serverpack-1.45/LaunchServer.sh
+ export FTB_DIR=/data/FeedTheBeast/RAD-Serverpack-1.45
+ FTB_DIR=/data/FeedTheBeast/RAD-Serverpack-1.45
+ chmod a+x /data/FeedTheBeast/RAD-Serverpack-1.45/LaunchServer.sh
+ grep fml.queryResult=confirm /data/FeedTheBeast/RAD-Serverpack-1.45/LaunchServer.sh
+ sed -i 's/.*read.*Restart now/#\0/' /data/FeedTheBeast/RAD-Serverpack-1.45/LaunchServer.sh
+ legacyJavaFixerPath=/data/FeedTheBeast/RAD-Serverpack-1.45/mods/legacyjavafixer.jar
+ isTrue
+ local value=

=
+ case ${value} in
+ result=1
+ return 1
+ '[' -e /data/FeedTheBeast/RAD-Serverpack-1.45/FTBInstall.sh ']'
+ '[' -e /data/FeedTheBeast/RAD-Serverpack-1.45/Install.sh ']'
+ exec /start-finalSetupWorld

d
+ export LEVEL
+ '[' CURSEFORGE = FEED-THE-BEAST ']'
+ worldDest=/data/world
+ [[ -n '' ]]
+ exec /start-finalSetupModpack
+ CURSE_URL_BASE=https://minecraft.curseforge.com/projects
+ isTrue
+ local value=

=
+ case ${value} in
+ result=1
+ return 1
+ [[ -n '' ]]
+ [[ -n '' ]]
+ [[ -n '' ]]
+ [[ -n '' ]]
+ exec /start-finalSetupModconfig
+ '[' -d /plugins ']'
+ : /data/mods
+ '[' -d /mods ']'
+ : /data/config
+ '[' -d /config ']'
+ exec /start-finalSetupServerProperties
[init] Creating whitelist
[init] Setting whitelist to 'true' in /data/server.properties
[init] Setting white-list to 'true' in /data/server.properties
[init] Setting server-name to 'Dedicated Server' in /data/server.properties
[init] Skip setting server-ip
[init] Setting server-port to '25565' in /data/server.properties
[init] Setting motd to 'RAD V1.45' in /data/server.properties
[init] Skip setting allow-nether
[init] Skip setting announce-player-achievements
[init] Skip setting enable-command-block
[init] Skip setting spawn-animals
[init] Skip setting spawn-monsters
[init] Skip setting spawn-npcs
[init] Skip setting spawn-protection
[init] Skip setting generate-structures
[init] Skip setting view-distance
[init] Skip setting hardcore
[init] Skip setting snooper-enabled
[init] Skip setting max-build-height
[init] Skip setting force-gamemode
[init] Skip setting max-tick-time
[init] Skip setting enable-query
[init] Skip setting query.port
[init] Setting enable-rcon to 'true' in /data/server.properties
[init] Setting rcon.password to 'minecraft' in /data/server.properties
[init] Setting rcon.port to '25575' in /data/server.properties
[init] Setting max-players to '4' in /data/server.properties
[init] Skip setting max-world-size
[init] Setting level-name to 'world' in /data/server.properties
[init] Skip setting level-seed
[init] Skip setting pvp
[init] Skip setting generator-settings
[init] Setting online-mode to 'true' in /data/server.properties
[init] Setting allow-flight to 'true' in /data/server.properties
[init] Skip setting level-type
[init] Skip setting resource-pack
[init] Skip setting resource-pack-sha1
[init] Skip setting player-idle-timeout
[init] Skip setting broadcast-console-to-ops
[init] Skip setting broadcast-rcon-to-ops
[init] Skip setting enable-jmx-monitoring
[init] Skip setting sync-chunk-writes
[init] Skip setting enable-status
[init] Skip setting entity-broadcast-range-percentage
[init] Skip setting function-permission-level
[init] Skip setting network-compression-threshold
[init] Skip setting op-permission-level
[init] Skip setting prevent-proxy-connections
[init] Skip setting use-native-transport
[init] Skip setting enforce-whitelist
[init] DEBUG Dumping server.properties
op-permission-level=4
allow-nether=true
level-name=world
enable-query=false
allow-flight=true
announce-player-achievements=true
server-port=25565
rcon.port=25575
query.port=25565
level-type=DEFAULT
enable-rcon=true
force-gamemode=false
level-seed=
server-ip=
max-tick-time=60000
max-build-height=256
spawn-npcs=true
white-list=true
spawn-animals=true
hardcore=false
snooper-enabled=true
texture-pack=
online-mode=true
resource-pack=
resource-pack-sha1=
pvp=true


difficulty=1
enable-command-block=true
player-idle-timeout=0
gamemode=0
max-players=4
spawn-monsters=true
generate-structures=true
view-distance=10
spawn-protection=16
motd=RAD V1.45
generator-settings=
rcon.password=minecraft
max-world-size=29999984
broadcast-console-to-ops=true
broadcast-rcon-to-ops=true
enable-jmx-monitoring=false
sync-chunk-writes=true
enable-status=true
entity-broadcast-range-percentage=100
function-permission-level=2
network-compression-threshold=256
op-permission-level=4
prevent-proxy-connections=false
use-native-transport=true
enforce-whitelist=false
server-name=Dedicated Server
+ '[' -n DianaChan_ ']'
+ log 'Updating ops'
+ echo '[init] Updating ops'
+ rm -f /data/ops.txt.converted
[init] Updating ops
+ echo Player1
+ awk -v RS=, '{print}'
+ isTrue ''
+ local value=

=
+ case ${value} in
+ result=1
+ return 1
+ '[' -n Player1,Player2 ']'
+ log 'Updating whitelist'
[init] Updating whitelist
+ echo '[init] Updating whitelist'
+ rm -f /data/white-list.txt.converted
+ echo Player1,Player2
+ awk -v RS=, '{print}'
+ isTrue ''
+ local value=

=
+ case ${value} in
+ result=1
+ return 1
+ '[' -n '' ']'
+ isTrue false
+ local value=false

=
+ case ${value} in
+ result=1
+ return 1
+ log 'Checking for JSON files.'
+ echo '[init] Checking for JSON files.'
[init] Checking for JSON files.
++ find /data -maxdepth 1 -name '*.json'
+ JSON_FILES=
+ versionLessThan 1.14
+ local activeParts
+ IFS=.
+ read -ra activeParts
+ local givenParts
+ IFS=.
+ read -ra givenParts
+ (( 3 < 2 ))
+ (( 3 == 2 ))
+ (( activeParts[0] < givenParts[0] ))
+ (( activeParts[0] == givenParts[0] && activeParts[1] < givenParts[1] ))
+ (( activeParts[0] == givenParts[0] && activeParts[1] == givenParts[1] && activeParts[2] < givenParts[2] ))
+ return 1
+ [[ '' = false ]]
+ [[ '' = FALSE ]]
+ log 'Setting initial memory to 4G and max to 4G'
+ echo '[init] Setting initial memory to 4G and max to 4G'
+ expandedDOpts=
+ '[' -n '' ']'
+ isTrue
+ local value=

=
+ case ${value} in
[init] Setting initial memory to 4G and max to 4G
+ result=1
+ return 1
+ isTrue ''
+ local value=

=
+ case ${value} in
+ result=1
+ return 1
+ isTrue ''
+ local value=

=
+ case ${value} in
+ result=1
+ return 1
+ isTrue ''
+ local value=

=
+ case ${value} in
+ result=1
+ return 1
+ isTrue ''
+ local value=

=
+ case ${value} in
+ result=1
+ return 1
+ JVM_OPTS='-Xms4G -Xmx4G '
+ mcServerRunnerArgs='--stop-duration 60s'
+ [[ CURSEFORGE == \C\U\R\S\E\_\I\N\S\T\A\N\C\E ]]
+ [[ CURSEFORGE == \C\U\R\S\E\F\O\R\G\E ]]
+ [[ -n '' ]]
+ [[ CURSEFORGE == \C\U\R\S\E\F\O\R\G\E ]]
+ mcServerRunnerArgs='--stop-duration 60s --shell bash'
+ copyFilesForCurseForge
+ '[' -f /data/ops.txt ']'
+ cp -f /data/ops.txt /data/FeedTheBeast/RAD-Serverpack-1.45/
+ '[' -f /data/white-list.txt ']'
+ cp -f /data/white-list.txt /data/FeedTheBeast/RAD-Serverpack-1.45/
+ '[' '!' -e /data/FeedTheBeast/RAD-Serverpack-1.45/server-icon.png -a -e /data/server-icon.png ']'
+ cp -f /data/eula.txt /data/FeedTheBeast/RAD-Serverpack-1.45/
+ cat
+ '[' -f /data/FeedTheBeast/RAD-Serverpack-1.45/settings.cfg ']'
+ cd /data/FeedTheBeast/RAD-Serverpack-1.45
+ log 'Running FTB /data/FeedTheBeast/RAD-Serverpack-1.45/LaunchServer.sh in /data/FeedTheBeast/RAD-Serverpack-1.45 ...'
[init] Running FTB /data/FeedTheBeast/RAD-Serverpack-1.45/LaunchServer.sh in /data/FeedTheBeast/RAD-Serverpack-1.45 ...
+ echo '[init] Running FTB /data/FeedTheBeast/RAD-Serverpack-1.45/LaunchServer.sh in /data/FeedTheBeast/RAD-Serverpack-1.45 ...'
+ finalArgs=("${FTB_SERVER_START}")
+ isTrue
+ local value=

=
+ case ${value} in
+ result=1
+ return 1
+ isTrue false
+ local value=false

=
+ case ${value} in
+ result=1
+ return 1
+ exec mc-server-runner --stop-duration 60s --shell bash /data/FeedTheBeast/RAD-Serverpack-1.45/LaunchServer.sh

[BlueDragon709]

That's strange, it should have already been supported at

https://github.com/itzg/docker-minecraft-server/blob/75f5a430e48e85f24e8339aba8c00ecd70ba2366/start-finalSetupServerProperties#L185

I pushed an image update that wraps that path in quotes; however, RAD doesn't expand to a path with spaces in the name.

See if the latest image happens to fix it for you. If not, add DEBUG: "true" to the variables and provide that output.

and the type is CURSEFORGE and not FEED-THE-BEAST in this issue

[itzg]

Thanks, your debug output helped me realize that bug too. There a mismatch in one of my multiarch merges in the past.

[itzg]

This should now be fixed in the latest java8-multiarch image tag.

[BlueDragon709]

Sorry for the late response.

from my testing it seems to work now. But now I see that i have 2 whitelist properties.

whitelist

and

white-list

which seems weird. But my issue has been resolved

[itzg]

I hadn't noticed recently that the startup script adds both forms of that property, where white-list is the correct one. The other might have been added for really old server versions, but I'm not easily finding that in the git history.