Update cadvisor in example for ARM64 runtime

itzg / mc-monitor

Monitor the status of Minecraft servers and provides Prometheus exporter and Influx line protocol output

MIT License

236 stars 30 forks source link

Open VladimirKuletski opened 2 years ago

VladimirKuletski commented 2 years ago

More of improvement request than issue.

cadvisor latest image is not working on ARM64 platform (OCI) Used zcube/cadvisor image as it has pre-compiled ARM64 platform. Works as expected. Googled that gcr.io/cadvisor/cadvisor:v0.45.0 should have ARM64. Didn't have time to check.
cadvisor permissions Required to add privileged: true on Ubuntu to be able to get metrics data. Not sure if it is required for all OS flavors and should go into commit.

itzg commented 2 years ago

Did you mean to post this here? The latest mc-monitor image is already multi-architecture including arm64.

VladimirKuletski commented 2 years ago

https://github.com/itzg/mc-monitor/blob/39fdbfebb2a2eb465bae61a3ea1f25e1466c2d66/examples/mc-monitor-prom/docker-compose.yml#L22 has reference to cadvisor image. This is what I had to change to make this example work + priviledged mode. Sorry for confusion missed file reference initially

itzg commented 2 years ago

Thanks for clarifying. Now that makes sense!