Closed uhthomas closed 1 year ago
Do you mind reverting the auto whitespace changes?
Can do, all of them or just some? I noticed this project doesn't seem to have a standard.
Do you mind reverting the auto whitespace changes?
Can do, all of them or just some? I noticed this project doesn't seem to have a standard.
Ones you adjusted are good. Thanks.
Yeah, this is an inherited project, so I'm sure it's quite inconsistent.
Looks like CI fails because there is nothing mounted to the required volume /opt/rcon-web-admin/db
as stated in https://github.com/itzg/docker-rcon-web-admin.
Is it okay for this to be an ephemeral directory, or does it require persistence?
Looks like CI fails because there is nothing mounted to the required volume
/opt/rcon-web-admin/db
as stated in https://github.com/itzg/docker-rcon-web-admin.Is it okay for this to be an ephemeral directory, or does it require persistence?
Ephemeral is totally fine. I guess that chart hasn't been re-built in a long time.
Looks like CI fails because there is nothing mounted to the required volume
/opt/rcon-web-admin/db
as stated in https://github.com/itzg/docker-rcon-web-admin. Is it okay for this to be an ephemeral directory, or does it require persistence?Ephemeral is totally fine. I guess that chart hasn't been re-built in a long time.
Thanks, all looks good now I think!
Ready for me to merge?
Ready for me to merge?
Yep, all looks good to me.
Use a strict security context by default to comply with the restricted pod security policy.
Fixes #154