itzg / minecraft-server-charts

MIT License
279 stars 144 forks source link

use strict security context #155

Closed uhthomas closed 1 year ago

uhthomas commented 1 year ago

Use a strict security context by default to comply with the restricted pod security policy.

Fixes #154

itzg commented 1 year ago

...and maybe related https://github.com/itzg/minecraft-server-charts/actions/runs/5146374308/jobs/9265335257?pr=155#step:7:61

uhthomas commented 1 year ago

Do you mind reverting the auto whitespace changes?

Can do, all of them or just some? I noticed this project doesn't seem to have a standard.

itzg commented 1 year ago

Do you mind reverting the auto whitespace changes?

Can do, all of them or just some? I noticed this project doesn't seem to have a standard.

Ones you adjusted are good. Thanks.

Yeah, this is an inherited project, so I'm sure it's quite inconsistent.

uhthomas commented 1 year ago

Looks like CI fails because there is nothing mounted to the required volume /opt/rcon-web-admin/db as stated in https://github.com/itzg/docker-rcon-web-admin.

Is it okay for this to be an ephemeral directory, or does it require persistence?

itzg commented 1 year ago

Looks like CI fails because there is nothing mounted to the required volume /opt/rcon-web-admin/db as stated in https://github.com/itzg/docker-rcon-web-admin.

Is it okay for this to be an ephemeral directory, or does it require persistence?

Ephemeral is totally fine. I guess that chart hasn't been re-built in a long time.

uhthomas commented 1 year ago

Looks like CI fails because there is nothing mounted to the required volume /opt/rcon-web-admin/db as stated in https://github.com/itzg/docker-rcon-web-admin. Is it okay for this to be an ephemeral directory, or does it require persistence?

Ephemeral is totally fine. I guess that chart hasn't been re-built in a long time.

Thanks, all looks good now I think!

itzg commented 1 year ago

Ready for me to merge?

uhthomas commented 1 year ago

Ready for me to merge?

Yep, all looks good to me.