search

itzg / minecraft-server-charts

MIT License
279 stars 144 forks source link

Option to deploy server as StatefulSet #163

Closed FroznMine closed 1 year ago

FroznMine commented 1 year ago

Some time ago #84 proposed to have the Minecraft servers deployed as StatefulSets. Due to possible problems with servers becoming too 'sticky' the idea was discarded. As I want to use this chart in conjunction with the auto-scale-up of mc-router, I need to deploy as a StatefulSet.

This PR adds workloadAsStatefulSet as a flag to deploy the servers (Java/Bedrock) as Deployment or StatefulSet. When deploying as a StatefulSet with persistence enabled, a PVC template is configured using the information that would have been used to create a single PVC in case of a Deployment.

danielr1996 commented 1 year ago

Any progress on this? Is there only the version that needs to be bumped or are there more things to do?

Also I was wondering if there are reasons to choose a deployment over a statefulset, or if it would be fine to only ever use a statefulset because this would mean a lot less to maintain.

itzg commented 1 year ago

Yes it looks like just the version bump and confirmation of testing enabled and disabled.

danielr1996 commented 1 year ago

I've opened a new PR https://github.com/itzg/minecraft-server-charts/pull/172/ with the bumped version, can verify that it creates a deployment or statefulset, depending on the setting.