Closed hrntknr closed 1 year ago
I set PreferDualStack as the default policy, the yaml without the value would be as follows.
# Source: minecraft/templates/minecraft-svc.yaml
apiVersion: v1
kind: Service
metadata:
name: minecraft-minecraft
labels:
app: minecraft-minecraft
chart: "minecraft-4.9.5"
release: "minecraft"
heritage: "Helm"
app.kubernetes.io/name: "minecraft"
app.kubernetes.io/instance: minecraft-minecraft
app.kubernetes.io/version: "4.9.5"
annotations:
{}
spec:
type: ClusterIP
ipFamilyPolicy: PreferDualStack
ports:
- name: minecraft
port: 25565
targetPort: minecraft
protocol: TCP
selector:
app: minecraft-minecraft
Thanks for the review. You are right, it would be better to make it more generalized as extraServiceSpec. We will implement and propose extraServiceSpec in another PR.
Add support for ipFamilyPolicy,ipFamilies. ref: https://kubernetes.io/docs/concepts/services-networking/dual-stack/
The actual output of yaml when values are not specified is as follows.
ipFamilyPolicy,ipFamilies can be specified as follows