search

itzg / minecraft-server-charts

MIT License
267 stars 142 forks source link

Added extraDeploy array #170

Closed grantbruneau closed 1 year ago

grantbruneau commented 1 year ago

Adds extraDeploy array which allows us to include additional objects at deployment. My reason for this is to use helm pre-install/post-delete hooks which can automatically add/remove DNS entries for my minecraft servers.

Reference

itzg commented 1 year ago

The lint build failure probably isn't related to your change, but I'm not sure yet why it fails with

curl: (6) getaddrinfo() thread failed to start
grantbruneau commented 1 year ago

The lint build failure probably isn't related to your change, but I'm not sure yet why it fails with

curl: (6) getaddrinfo() thread failed to start

Looks like there was an error downloading bedrock at that moment. Can we retry the lint? I confirmed that URL works. ERROR failed to download from https://minecraft.azureedge.net/bin-linux/bedrock-server-1.20.15.01.zip

itzg commented 1 year ago

Had already re-run, but was waiting to try again today since it might have been a github workflow networking issue.

itzg commented 1 year ago

Still failing in the same way. I really don't think it's related to your changes, so I'll experiment with a PR with no changes from master.

grantbruneau commented 1 year ago

Seems like it might be the github runner, has anything changed on that end? My googling says maybe firewall issue.

Edit: Actually, this is all from within KIND, so maybe not runner specifically.

grantbruneau commented 1 year ago

@itzg I have it working on my fork. I updated the versions of KIND and metallb. Prior to that I had the same errors.

reference

itzg commented 1 year ago

Thanks! Running it now

itzg commented 1 year ago

Awesome, that fixed it. Thanks for digging into that.

grantbruneau commented 1 year ago

Happy to help!