search

itzg / minecraft-server-charts

MIT License
279 stars 144 forks source link

Add MC Router chart #177

Closed Bibz87 closed 1 year ago

Bibz87 commented 1 year ago

This will enable MC Router deployment using Helm.

Chart was built using MC Router's regular YAML example file and other existing charts.

itzg commented 1 year ago

Unfortunately, I'm not familiar with how the chart testing tool works or what it expects. I'm sure the chart itself is fine, but would be nice to get the test automation happy:

https://github.com/itzg/minecraft-server-charts/actions/runs/6734798515/job/18314217048?pr=177

Bibz87 commented 1 year ago

Unfortunately, I'm not familiar with how the chart testing tool works or what it expects. I'm sure the chart itself is fine, but would be nice to get the test automation happy:

https://github.com/itzg/minecraft-server-charts/actions/runs/6734798515/job/18314217048?pr=177

I'll take a look at that. :)

itzg commented 1 year ago

It looks like files like https://github.com/itzg/minecraft-server-charts/blob/master/charts/minecraft/ci/test-values.yaml get used as input to the test, but the default values should have been fine in this case.

Bibz87 commented 1 year ago

It looks like files like https://github.com/itzg/minecraft-server-charts/blob/master/charts/minecraft/ci/test-values.yaml get used as input to the test, but the default values should have been fine in this case.

Yeah the problem's the default ports:

Error: Service "mc-router-uhe6wa9e6h" is invalid: spec.ports[0].nodePort: Invalid value: 25565: provided port is not in the valid range. The range of valid ports is 30000-32767

itzg commented 1 year ago

...it says: ✔️