search

itzg / minecraft-server-charts

MIT License
279 stars 144 forks source link

Allow setting `priorityClassName` #204

Closed josephshanak closed 6 months ago

josephshanak commented 6 months ago

It would be nice if I could set priorityClassName for pods created by the chart so I can control when the pods are pre-empted.

See https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/

I propose we add priorityClassName to values

minecraftServer:
    priorityClassName: ''

And include it in the deployment pod spec:

     priorityClassName: "{{ .Values.priorityClassName }}"
itzg commented 6 months ago

Great idea. I would prefer to introduce a general purpose "extraPodSpec" values object to allow for such items. Otherwise the logical conclusion becomes mirroring the entire pod spec into chart values.

josephshanak commented 6 months ago

+1 For "extraPodSpec".