search

itzg / minecraft-server-charts

MIT License
279 stars 144 forks source link

Helm Chart - Passing Namespace not working #210

Open ryanchauvin opened 5 months ago

ryanchauvin commented 5 months ago

Helm supports -n or --namespace string to set the namespace on Deployments, Services, etc. This is not working on mc-router helm charts when doing --dry-run. It does deploy to the correct namespace, but you can not see the Namespace when doing --dry-run.

Could we have this fixed?

You can use namespace: {{ .Release.Namespace }} to accomplish this.

See examples below:

apiVersion: v1 kind: ServiceAccount metadata: name: example namespace: {{ .Release.Namespace }}

apiVersion: apps/v1 kind: DaemonSet metadata: name: example-ds namespace: {{ .Release.Namespace }}

itzg commented 5 months ago

Submitting a PR to fix this would be great.

ryanchauvin commented 5 months ago

I can do that, let me pull down the helm chart and do some testing. I'll start with mc-router, then do the same for the rest. I'll submit a PR once I validate it's working as expected.