itzg / minecraft-server-charts

MIT License
278 stars 143 forks source link

mc-router: Add extraServiceSpec for customizing services #216

Closed Edouard127 closed 3 months ago

Edouard127 commented 3 months ago

This pull request adds the extraServiceSpec field inside the service object in the values.yaml Allows for more flexibility on the user end Closes #215

Edouard127 commented 3 months ago

Sure thing, I also noticed that the appVersion does not match the current release for itzg/mc-router https://github.com/itzg/mc-router/releases/latest Should I bump this version too ?

itzg commented 3 months ago

I also noticed that the appVersion does not match the current release for itzg/mc-router

https://github.com/itzg/mc-router/releases/latest

Should I bump this version too ?

Nah, it doesn't need to match up.

Edouard127 commented 3 months ago

All good then !