search

itzg / minecraft-server-charts

MIT License
279 stars 144 forks source link

minecraft: unused deprecated serviceAnnotations property #219

Open Edouard127 opened 3 months ago

Edouard127 commented 3 months ago

The minecraftServer.serviceAnnotations field present at https://github.com/itzg/minecraft-server-charts/blob/197dcf3bfb2bbe8dae1d78e73e61a3878f2e5658/charts/minecraft/values.yaml#L257-L258 is not being used

We can confuse it with the real serviceAnnotations field present in the root level, thus applying no annotations to the service https://github.com/itzg/minecraft-server-charts/blob/197dcf3bfb2bbe8dae1d78e73e61a3878f2e5658/charts/minecraft/values.yaml#L428 used at https://github.com/itzg/minecraft-server-charts/blob/197dcf3bfb2bbe8dae1d78e73e61a3878f2e5658/charts/minecraft-bedrock/templates/minecraft-svc.yaml#L13-L17

As of 2024-08-06, the minecraftServer.serviceAnnotations is not used, which means that we can safely remove it

Because it's not worth creating a new release simply to remove a deprecated field, someone can reference this issue in the next release pull request to remove it