Open drewburr opened 2 months ago
Some questions I ran into while doing initial rework:
1) Do we need to support a Deployment and StatefulSet type? I've always been under the impression that Minecraft can't run dual-instance in any circumstance, so using StatefulSet seems like the right option, but other charts seem to be using Deployments with strategyType: Recreate
. This effectively does the same thing as a STS, so I'm interested in knowing more about the potential use-case. IMO, supporting both seems unnecessarily complicated. My sentiment matches the below references, I feel a StatefulSet is supportive of the expectations a Minecraft server has (one instance and only ever once instance)
Perhaps someone like @Robbilie could help here. (Ref: #98)
2) How, if at all, should the chart maintainers list be revised? I don't feel that I'm in a good place to make this decision, and wanted to toss it out there since there may be opportunity for cleanup.
3) Should we build in / hint at the integrations for other charts, such as mc-router
and mc-monitor
? This could be things such as commented service annotations and service monitors that are disabled by default. I personally like this option, because it supports other parts of the itgz ecosystem.
I'm still leaning towards StatefulSet with no setting to go beyond one replica. A StatefulSet actually extends all the features of Deployment including being a ReplicaSet...but as you mentioned there can only ever be one replica active for the server data volume at a time.
Myself and @billimek are the only active maintainers. So the two of us and yourself would be appropriate as chart maintainers IMHO
Loosely integrating would be nice somehow vs bringing all of those parts over.
That latest build failure sounds similar to something that was fixed recently
https://github.com/itzg/minecraft-server-charts/pull/222
Perhaps double check you started from the very latest revision or just bring any deltas.
In regards to my past PR:
I built a software in front of the Minecraft Servers to keep them in sync. Behind this proxying software normal Minecraft Servers are used, for that I was using this chart.
Without an external way of keeping sync more than one replica will not be the desired use of this chart but as stated back then I would have otherwise had to create a fork of this chart and I was really grateful that instead we went with the replicaCount value and the big warning. I would appreciate keeping this :)
Following discussion in #225, opening this up to contain the conversation in regards to the creation of a chart to refactor and ultimately replace the existing
minecraft
chart. This new chart will be namedminecraft-server
to pair with itzg/docker-minecraft-server.Goals of the refactor:
itzg/docker-minecraft-server
. Using the chart shouldn't feel like learning a new toolIt was suggested that merging
minecraft-bedrock
into this new chart could be a goal, but it was agreed that this should be more of a long term goal. This effort should be closer to a rework of the existing chart, keeping in mind that it may need to be flexible to later include the bedrock chart.