search

iu-parfunc / HSBencher

General benchmarking framework. Especially good at parameter studies.
13 stars 8 forks source link

Export orphan Functor instances from base-orphans #91

Closed RyanGlScott closed 9 years ago

RyanGlScott commented 9 years ago

Currently, hsbencher defines orphan Functor instances for OptDescr and ArgDescr. However, there is at least one other package that exports these same orphan instances (test-framework), possibly others. If these packages were used together on an old version of GHC, it could lead to instance conflicts.

To help mitigate this possibility, this pull request imports these instances from the base-orphans library (which exports backported instances introduced in later versions of base, including the aforementioned ones). This way, we can keep all of these orphan instances in one package so that hsbencher, test-framework, etc. can coexist.

rrnewton commented 9 years ago

Nice, thanks! I see it passes on travis -- merging.