search

iulianraduat / react-select-material-ui

A react SELECT component based on react-select and looking like a material-ui component
MIT License
73 stars 18 forks source link

MUI v5 migration #44

Closed denneulin closed 3 years ago

denneulin commented 3 years ago

Hi,

Thanks for your great library. Do you plan to migrate to mui v5 ?

It requires to replace your dependency @material-ui/core by @mui/material

Actually it is not possible to migrate to mui v5 when using your lib because of this https://github.com/mui-org/material-ui/pull/28907/files

iulianraduat commented 3 years ago

Hi @denneulin,

What you mean by Actually it is not possible to migrate to mui v5 when using your lib because of this https://github.com/mui-org/material-ui/pull/28907/files?

In your opinion, should be material-ui/mui a peerDependencies?

Thanks, Iulian

denneulin commented 3 years ago

When migrating my projet from material-ui (v4) to mui (v5), my design is completely broken. It seems to be because there is still a dependency to @material-ui/core and it comes from react-select-material-ui.

In v5, @material-ui/core has been replaced by @mui/material

They published a migration guide here https://mui.com/guides/migration-v4/

iulianraduat commented 3 years ago

Hi @denneulin ,

Please install v8 and check if your problem was solved. Let me also know if it works.

Thanks, Iulian

denneulin commented 3 years ago

Hi Iulian,

Thanks for your new version. It seems to fix my issues, thanks a lot 👏

Do you plan to push it to npm anytime soon ?

iulianraduat commented 3 years ago

Already published 😃 Install version 8.0.0

Thanks for your feedback.

denneulin commented 3 years ago

oh right sorry. I was looking at the wrong npm package, it is deployed twice here https://www.npmjs.com/package/react-select-material-ui and here https://www.npmjs.com/package/react-select-material-ui-tags

iulianraduat commented 3 years ago

I still need to update all other packages depending on it. I did not knew that you are using the other one. I will inform you once the other one is updated. The one ending in - tags is a mistake. Please do not use it. I will deprecate it.

iulianraduat commented 3 years ago

UPDATE: it looks like, one year ago, someone called Farhan Tariq published 3 packages with different names but all of them pointing to my react-select-materia-ui. Please do not use them. The three packages are: