search

iulspop / slack-web-scraper

Puppeteer configured to scrape the posts and threads of any channel on Slack.
MIT License
69 stars 23 forks source link

New feature: skip threads parsing #4

Closed williamdes closed 2 years ago

williamdes commented 2 years ago

Ref: #2

williamdes commented 2 years ago

💤 Will continue tomorrow if your review needs changes ;)

iulspop commented 2 years ago

Can you refactor this to access the SKIP_THREADS env var directly in extractPostsHTML.js instead of passing it down from scrape/index.js?

williamdes commented 2 years ago

Can you refactor this to access the SKIP_THREADS env var directly in extractPostsHTML.js instead of passing it down from scrape/index.js?

Done, sorry for the very long delay

iulspop commented 2 years ago

Thanks! I will review this soon.

iulspop commented 2 years ago

Great PR! Thanks for adding this feature :)