search

iulspop / slack-web-scraper

Puppeteer configured to scrape the posts and threads of any channel on Slack.
MIT License
69 stars 22 forks source link

Add a test CI and fix a TZ depdendent test #7

Closed williamdes closed 2 years ago

williamdes commented 2 years ago

It works: https://github.com/williamdes/slack-web-scraper/actions/runs/2920670384

iulspop commented 2 years ago

This looks cool. A CI test running on PRs will be very helpful :)

For the TZ-dependent tests, you're setting the Node environment time zone which makes the parsing of dates consistent when running tests in different time zones. Is my understanding correct?

Once you confirm, I'll merge the PR.

williamdes commented 2 years ago

This looks cool. A CI test running on PRs will be very helpful :)

Yup !

For the TZ-dependent tests, you're setting the Node environment time zone which makes the parsing of dates consistent when running tests in different time zones. Is my understanding correct?

Yes, this is exactly what it is doing :)

iulspop commented 2 years ago

Great!