search

iunderwood / uhq_geolocate

UHQ XOOPS GeoLocation Module
GNU General Public License v2.0
1 stars 1 forks source link

Errors when choosing Location provider #3

Open cesagonchu opened 9 years ago

cesagonchu commented 9 years ago

Depending on the preferences that I choose from the dropdown menus for Location Provider, I get these errors by displaying the module's block: Notice: Undefined index: in file /modules/uhq_geolocate/class/maxmindweb.class.php line 91 Notice: Uninitialized string offset: 0 in file /modules/uhq_geolocate/class/geolocate.class.php line 497 Notice: Undefined index: in file /modules/uhq_geolocate/blocks/uhqgeo_blocks.php line 22

My config:

PHP: 5.5.9-1ubuntu4.11 MYSQL: 5.5.43-0ubuntu0.14.04.1 XOOPS: 2.5.7.1

Xoops and the module are in english

iunderwood commented 9 years ago

From what I can tell, it looks like the API is returning a country code that the module is ill-equipped to handle. Can you share an IP with me where you're at so I can try and duplicate this?

cesagonchu commented 9 years ago

Ok, I sent to you by email :-)

iunderwood commented 9 years ago

Just putting this in for the Github record.

There is a section of the code which does not properly handle the error conditions when they're presented by the API providers. So instead of returning an appropriate error code, it just returns (and caches if applicable) an empty record which fits the reported errors. I'm away for business all week so I should be able to roll out a fix next week which incorporates this. :+1:

iunderwood commented 9 years ago

It looks like I missed the error trapping for the two API providers there were problems with. I believe this is now fixed and will be a part of the v0.97 rollup!