search

iusrepo / httpd24u

Apache HTTP Server
17 stars 14 forks source link

Updated httpd24u for 2.4.43 #35

Closed SteveSimpson closed 4 years ago

SteveSimpson commented 4 years ago

I didn't see what's breaking the RHEL 6 build. It would have to be one of the 2 patches that I just added. I suspect that it is actually the fact that "detect-systemd" patch is not being as the code changed in makefile and configure.in don't seem to actually have anything to do with systemd. It is changing which set of libraries are being used.

SteveSimpson commented 4 years ago

Looking at the selinux patch, + APR_ADDTO(HTTPD_LIBS, [-lselinux]) in is applied.

But without the change in detect systemd: 

-PROGRAM_LDADD        = buildmark.o $(HTTPD_LDFLAGS) $(PROGRAM_DEPENDENCIES) $(PCRE_LIBS) $(EXTRA_LIBS) $(AP_LIBS) $(LIBS)
+PROGRAM_LDADD        = buildmark.o $(HTTPD_LDFLAGS) $(PROGRAM_DEPENDENCIES) $(HTTPD_LIBS) $(EXTRA_LIBS) $(AP_LIBS) $(LIBS)

HTTPD_LIBS would not be used. Looks like the new detect.systemd patch needs to be ran on 6 as as well as 7.

carlwgeorge commented 4 years ago

Thanks for the investigation on the detect-systemd patch, I agree with your findings. Always applying it is fine.

I added a few more commits for clean up, this should be good to go now once the CI passes.